Skip to content

[skip changelog] Update release process #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2021
Merged

[skip changelog] Update release process #1148

merged 5 commits into from
Jan 22, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Updates the process used to create new builds and releases.

  • What is the current behavior?

We currently use goreleaser to create changelogs and new releases.

  • What is the new behavior?

We ditch goreleaser, we use Task and different Docker containers to create dist files for different platforms.

Nope.

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza added the topic: documentation Related to documentation for the project label Jan 21, 2021
@silvanocerza silvanocerza requested review from per1234 and rsora January 21, 2021 18:03
@silvanocerza silvanocerza self-assigned this Jan 21, 2021
per1234
per1234 requested changes Jan 22, 2021
View reviewed changes
@per1234 per1234 added component/packaging and removed topic: documentation Related to documentation for the project labels Jan 22, 2021
@silvanocerza
Copy link
Contributor Author

I just pushed another commit that changes the VERSION variable in the Taskfile.yml from snapshot to git-snapshot, we use that version string when running lib install using the --git-url or --zip-file flags to print the documentation version.

This is the snippet in question, it panics at line 69 since the split slice contains only one element. Fact is that we should not enter that if at all when running tests.

arduino-cli/cli/lib/install.go

Lines 64 to 75 in 7e55f9e

if installFlags.zipPath || installFlags.gitURL {
if !configuration.Settings.GetBool("library.enable_unsafe_install") {
documentationURL := "https://arduino.github.io/arduino-cli/latest/configuration/#configuration-keys"
if !strings.Contains(globals.VersionInfo.VersionString, "git") {
split := strings.Split(globals.VersionInfo.VersionString, ".")
documentationURL = fmt.Sprintf("https://arduino.github.io/arduino-cli/%s.%s/configuration/#configuration-keys", split[0], split[1])
}
feedback.Errorf("--git-url and --zip-path are disabled by default, for more information see: %v", documentationURL)
os.Exit(errorcodes.ErrGeneric)
}
feedback.Print("--git-url and --zip-path flags allow installing untrusted files, use it at your own risk.")
}

per1234
per1234 requested changes Jan 22, 2021
View reviewed changes
per1234
per1234 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Silvano! Very exciting to have a new build system in place.

I ran the "nightly" and "release" workflows in my fork with my Apple signing certificate and verified that the macOS signing/notarization system is all working fine.

@silvanocerza silvanocerza merged commit 079bb6c into master Jan 22, 2021
@silvanocerza silvanocerza deleted the scerza/build-process branch January 22, 2021 13:41
silvanocerza added a commit that referenced this pull request Jan 27, 2021
@silvanocerza
[skip changelog] Update release process (#1148)
37a23e3 
* [skip changelog] Ditch goreleaser in favor of a new release process

* [skip changelog] Fix version output test

* [skip changelog] Fix some workflows issues

* [skip changelog] Fix panic when running integration tests

* [skip changelog] Remove extra chars from package name prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@rsora rsora Awaiting requested review from rsora

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @per1234