Skip to content

[gRPC] Check whether CompileReq#programmer is required #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kittaakos opened this issue Jul 23, 2020 · 0 comments · Fixed by #862
Closed

[gRPC] Check whether CompileReq#programmer is required #861

kittaakos opened this issue Jul 23, 2020 · 0 comments · Fixed by #862

Comments

@kittaakos
Copy link
Contributor

I have noticed, the CompileReq has the programmer field:

arduino-cli/rpc/commands/compile.proto

Line 43 in 3d74a8f

string programmer = 19; // External programmer for upload

One can trigger an automatic upload with the compile command from the command line by appending the -u (--upload) flag, but it is not possible to trigger an upload with the CompileReq via gRPC.

Long story short: the programmer seems superfluous. Please check whether it is needed or not.

Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed useless Compile.programmer parameter from GRPC interface cmaglie/arduino-cli
1 participant
@kittaakos