Skip to content

Core search command fails with uppercase framework #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmchiappa opened this issue May 18, 2020 · 1 comment
Closed

Core search command fails with uppercase framework #710

jmchiappa opened this issue May 18, 2020 · 1 comment
Labels
conclusion: resolved Issue was resolved topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project

Comments

@jmchiappa
Copy link

jmchiappa commented May 18, 2020 •
edited
Loading

Bug Report

Current behavior

executing arduino-cli.exe core search STM32 fails even if framework is already installed.

The search always fails due to the search code which put in lowercase :

arduino-cli/cli/core/search.go

Line 58 in ebc28e1

arguments := strings.ToLower(strings.Join(args, " "))

Expected behavior

Searching (e.g. 'STM32' for STM32duino) framework should return the expected framework with all supported version

Environment

  • CLI version : arduino-cli.exe Version: 0.10.0 Commit: ec5c3ed
  • OS and platform:
    windows 10 x64 build 18363

--- EDIT ---
Even after rebuilding a new version without the strings.ToLower it doesn't seem to work as expected.
Not sure about the behavior of this command...
@per1234 per1234 reopened this Mar 30, 2021
@rsora rsora removed the topic: CLI label Sep 16, 2021
@fstasi fstasi removed the type: bug label Sep 16, 2021
@rsora rsora added type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface labels Sep 22, 2021
@umbynos
Copy link
Contributor

umbynos commented Oct 18, 2022

This should be solved here #1904, please try it out

@umbynos umbynos closed this as completed Oct 18, 2022
@umbynos umbynos added the conclusion: resolved Issue was resolved label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fstasi @per1234 @jmchiappa @umbynos @rsora