Skip to content

[Feature request] include in homebrew/linuxbrew (OSX/Linux) #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
endorama opened this issue Jul 12, 2019 · 8 comments
Closed

[Feature request] include in homebrew/linuxbrew (OSX/Linux) #275

endorama opened this issue Jul 12, 2019 · 8 comments
Labels
os: linux Specific to Linux operating system os: macos Specific to macOS operating system type: enhancement Proposed improvement

Comments

@endorama
Copy link
Contributor

Would be nice to have the cli released through homebrew/linuxbrew also.

@Efrat19
Copy link
Contributor

Efrat19 commented Sep 25, 2019

Coming soon... 🤞
Homebrew/homebrew-core#44575

@Efrat19
Copy link
Contributor

Efrat19 commented Oct 7, 2019

all clear!
@masci @endorama my pr to homebrew was just merged,
can you review this one now? #437

@endorama
Copy link
Contributor Author

endorama commented Oct 7, 2019

@Efrat19 thank you! I've just installed it, and everything went perfectly on Linux.

@gvarisco can you please give it a go under MacOSX?

@gvarisco
Copy link
Contributor

gvarisco commented Oct 7, 2019

As a reference, PR for arduino-cli inclusion in homebrew is Homebrew/homebrew-core#44948 and got merged in Homebrew/homebrew-core@cdf88f3

Will let you know once I run a couple of tests.

@gvarisco gvarisco added os: macos Specific to macOS operating system os: linux Specific to Linux operating system labels Oct 7, 2019
@dawidd6
Copy link

dawidd6 commented Oct 7, 2019

Could someone confirm that running brew test arduino-cli does not produce an exception on macOS?

Running this command on linux results in an exception as arduino-cli writes the new sketch in ~/Arduino/test_sketch and in the formula test definition it is actually ~/Documents/Arduino/test_sketch ($HOME is set to testpath during test).

https://github.com/Homebrew/linuxbrew-core/pull/16040


Looking at https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/49337/version=mojave/testReport/brew-test-bot/mojave/test_arduino_cli/ one can see that the test is successful on macOS.

Had to make a workaround like this: https://github.com/Homebrew/linuxbrew-core/pull/16040/files

@gvarisco any idea why the new sketch is saved in different locations on macOS and linux?

@Efrat19
Copy link
Contributor

Efrat19 commented Oct 7, 2019

@dawidd6 as far as I saw this was fixed at arduino-cli0.5.0-showports, but you preferred not to use that version because it was a pre-release

@dawidd6
Copy link

dawidd6 commented Oct 7, 2019

@Efrat19 I see, thanks. Actually I was in favor of this -showports release, but anyway I workarounded it on linux for now.

@masci
Copy link
Contributor

masci commented Oct 22, 2019

Closing as fixed by https://formulae.brew.sh/formula/arduino-cli

@masci masci closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Specific to Linux operating system os: macos Specific to macOS operating system type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

5 participants