Skip to content

Remove daemon --ip flag #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umbynos opened this issue Jan 23, 2023 · 0 comments · Fixed by #2045
Closed

Remove daemon --ip flag #2044

umbynos opened this issue Jan 23, 2023 · 0 comments · Fixed by #2045
Assignees
@MatteoPologruto
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: security Related to the protection of user data type: enhancement Proposed improvement
Milestone
Arduino CLI 0.30.0

Comments

@umbynos
Copy link
Contributor

umbynos commented Jan 23, 2023

Currently, we offer a flag used to override the default ip used for the gRPC communication, at the time of the addition we didn't add any kind of authentication, delegating to the user the responsibility of exposing such a service. Since we do not have currently the bandwidth to do so, we are going to remove the --ip of the command daemon.
Kinda reverts #1651
@umbynos umbynos added topic: security Related to the protection of user data topic: code Related to content of the project itself labels Jan 23, 2023
@umbynos umbynos added this to the Arduino CLI 0.30.0 milestone Jan 23, 2023
@MatteoPologruto MatteoPologruto linked a pull request Jan 23, 2023 that will close this issue
[breaking] Remove ip flag from daemon command #2045
Merged
5 tasks
@per1234 per1234 added type: enhancement Proposed improvement conclusion: resolved Issue was resolved labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: security Related to the protection of user data type: enhancement Proposed improvement
Projects
None yet
Milestone
Arduino CLI 0.30.0
Development

Successfully merging a pull request may close this issue.

[breaking] Remove ip flag from daemon command MatteoPologruto/arduino-cli
3 participants
@per1234 @umbynos @MatteoPologruto