Skip to content

[gRPC] ArchiveSketchReq cannot override existing archives #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kittaakos opened this issue Feb 1, 2021 · 1 comment · Fixed by #1994
Closed

[gRPC] ArchiveSketchReq cannot override existing archives #1160

kittaakos opened this issue Feb 1, 2021 · 1 comment · Fixed by #1994
Assignees
@MatteoPologruto
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Milestone
Arduino CLI v1.0.0

Comments

@kittaakos
Copy link
Contributor

Bug Report

Current behavior

This is a follow-up of #931.

I want to archive a sketch with the gRPC API. It works, but I cannot override existing archives.

root ERROR Uncaught Exception:  Error: 2 UNKNOWN: archive already exists
root ERROR Error: 2 UNKNOWN: archive already exists
    at Object.callErrorFromStatus (/Users/akos.kitta/git/arduino-editor/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/Users/akos.kitta/git/arduino-editor/node_modules/@grpc/grpc-js/build/src/client.js:176:52)
    at Object.onReceiveStatus (/Users/akos.kitta/git/arduino-editor/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:334:141)
    at Object.onReceiveStatus (/Users/akos.kitta/git/arduino-editor/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:297:181)
    at /Users/akos.kitta/git/arduino-editor/node_modules/@grpc/grpc-js/build/src/call-stream.js:129:78

The Java IDE can override existing sketches, so we need this functionality on the CLI too. Please support forceOverride Thank you!

Expected behavior

Environment

  • CLI version (output of arduino-cli version): 0.15.0-rc1
  • OS and platform:

Additional context
@kittaakos kittaakos changed the title [gRPC] ArchiveSketchReq cannot override existing sketches [gRPC] ArchiveSketchReq cannot override existing archives Feb 1, 2021
@per1234 per1234 reopened this Mar 30, 2021
@rsora rsora added the topic: gRPC Related to the gRPC interface label Sep 22, 2021
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project and removed topic: gRPC Related to the gRPC interface labels Mar 31, 2022
@per1234
Copy link
Contributor

per1234 commented Mar 31, 2022

This also occurs when using arduino-cli sketch archive via the command line:

$ arduino-cli version
arduino-cli.exe  Version: nightly-20220331 Commit: 38ebf64 Date: 2022-03-31T01:34:02Z

$ arduino-cli sketch archive

$ arduino-cli sketch archive
Error archiving: Archive already exists

@umbynos umbynos added this to the Arduino CLI 1.0 milestone Nov 28, 2022
@umbynos umbynos assigned MatteoPologruto and unassigned ubidefeo Nov 28, 2022
@MatteoPologruto MatteoPologruto linked a pull request Nov 29, 2022 that will close this issue
Enable sketch archive overrides using overwrite flag #1994
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatteoPologruto MatteoPologruto

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
Arduino CLI v1.0.0
Development

Successfully merging a pull request may close this issue.

Enable sketch archive overrides using overwrite flag MatteoPologruto/arduino-cli
7 participants
@kittaakos @ubidefeo @AlbyIanna @per1234 @umbynos @rsora @MatteoPologruto