Added fqbn filtering for libraries

Author: cmaglie

Diff for: cli/lib/examples.go

@@ -35,24 +35,35 @@ import (
 
 func initExamplesCommand() *cobra.Command {
 	examplesCommand := &cobra.Command{
-		Use:     "examples LIBRARY_NAME",
-		Short:   "Shows the list of the examples for the given library.",
-		Long:    "Shows the list of the examples for the given library.",
+		Use:     "examples [LIBRARY_NAME]",
+		Short:   "Shows the list of the examples for libraries.",
+		Long:    "Shows the list of the examples for libraries. A name may be given as argument to search a specific library.",
 		Example: "  " + os.Args[0] + " lib examples Wire",
-		Args:    cobra.ExactArgs(1),
+		Args:    cobra.MaximumNArgs(1),
 		Run:     runExamplesCommand,
 	}
+	examplesCommand.Flags().StringVarP(&examplesFlags.fqbn, "fqbn", "b", "", "Show libraries for the specified board FQBN.")
 	return examplesCommand
 }
 
+var examplesFlags struct {
+	fqbn string
+}
+
 func runExamplesCommand(cmd *cobra.Command, args []string) {
 	instance := instance.CreateInstanceIgnorePlatformIndexErrors()
 	logrus.Info("Show examples for library")
 
+	name := ""
+	if len(args) > 0 {
+		name = args[0]
+	}
+
 	res, err := lib.LibraryList(context.Background(), &rpc.LibraryListReq{
 		Instance: instance,
 		All:      true,
-		Name:     args[0],
+		Name:     name,
+		Fqbn:     examplesFlags.fqbn,
 	})
 	if err != nil {
 		feedback.Errorf("Error getting libraries info: %v", err)

Diff for: cli/lib/list.go

@@ -42,13 +42,15 @@ func initListCommand() *cobra.Command {
 		Run:     runListCommand,
 	}
 	listCommand.Flags().BoolVar(&listFlags.all, "all", false, "Include built-in libraries (from platforms and IDE) in listing.")
+	listCommand.Flags().StringVarP(&listFlags.fqbn, "fqbn", "b", "", "Show libraries for the specified board FQBN.")
 	listCommand.Flags().BoolVar(&listFlags.updatable, "updatable", false, "List updatable libraries.")
 	return listCommand
 }
 
 var listFlags struct {
 	all       bool
 	updatable bool
+	fqbn      string
 }
 
 func runListCommand(cmd *cobra.Command, args []string) {
@@ -65,6 +67,7 @@ func runListCommand(cmd *cobra.Command, args []string) {
 		All:       listFlags.all,
 		Updatable: listFlags.updatable,
 		Name:      name,
+		Fqbn:      listFlags.fqbn,
 	})
 	if err != nil {
 		feedback.Errorf("Error listing Libraries: %v", err)

Diff for: commands/lib/list.go

@@ -17,8 +17,11 @@ package lib
 
 import (
 	"context"
+	"errors"
+	"fmt"
 	"strings"
 
+	"github.com/arduino/arduino-cli/arduino/cores"
 	"github.com/arduino/arduino-cli/arduino/libraries"
 	"github.com/arduino/arduino-cli/arduino/libraries/librariesindex"
 	"github.com/arduino/arduino-cli/arduino/libraries/librariesmanager"
@@ -33,13 +36,53 @@ type installedLib struct {
 
 // LibraryList FIXMEDOC
 func LibraryList(ctx context.Context, req *rpc.LibraryListReq) (*rpc.LibraryListResp, error) {
+	pm := commands.GetPackageManager(req.GetInstance().GetId())
+	if pm == nil {
+		return nil, errors.New("invalid instance")
+	}
+
 	lm := commands.GetLibraryManager(req.GetInstance().GetId())
+	if lm == nil {
+		return nil, errors.New("invalid instance")
+	}
 
 	nameFilter := strings.ToLower(req.GetName())
 
 	instaledLib := []*rpc.InstalledLibrary{}
 	res := listLibraries(lm, req.GetUpdatable(), req.GetAll())
 	if len(res) > 0 {
+		if f := req.GetFqbn(); f != "" {
+			fqbn, err := cores.ParseFQBN(req.GetFqbn())
+			if err != nil {
+				return nil, fmt.Errorf("parsing fqbn: %s", err)
+			}
+			_, boardPlatform, _, _, refBoardPlatform, err := pm.ResolveFQBN(fqbn)
+			if err != nil {
+				return nil, fmt.Errorf("loading board data: %s", err)
+			}
+
+			filteredRes := map[string]*installedLib{}
+			for _, lib := range res {
+				if cp := lib.Library.ContainerPlatform; cp != nil {
+					if cp != boardPlatform && cp != refBoardPlatform {
+						// Filter all libraries from extraneous platforms
+						continue
+					}
+				}
+				if latest, has := filteredRes[lib.Library.Name]; has {
+					if latest.Library.LocationPriorityFor(boardPlatform, refBoardPlatform) >= lib.Library.LocationPriorityFor(boardPlatform, refBoardPlatform) {
+						continue
+					}
+				}
+				filteredRes[lib.Library.Name] = lib
+			}
+
+			res = []*installedLib{}
+			for _, lib := range filteredRes {
+				res = append(res, lib)
+			}
+		}
+
 		for _, lib := range res {
 			if nameFilter != "" && strings.ToLower(lib.Library.Name) != nameFilter {
 				continue