skip changelog] CI test definitive edition

Author: silvanocerza

Diff for: .github/workflows/test.yaml

@@ -71,12 +71,6 @@ jobs:
         if: matrix.operating-system == 'ubuntu-latest'
         run: task test-legacy
 
-      - name: Test archive
-        if: matrix.operating-system == 'windows-latest'
-        run: |
-          cd "D:\a\arduino-cli\arduino-cli\client_example\hello" && "D:\a\arduino-cli\arduino-cli\arduino-cli.exe" archive
-          cd .. && dir
-
       - name: Run integration tests
         run: task test-integration
 

Diff for: test/conftest.py

@@ -102,7 +102,10 @@ def _run(cmd_string, custom_working_dir=None):
         # Context.cd() is not used since it doesn't work correctly on Windows.
         # It escapes spaces in the path using "\ " but it doesn't always work,
         # wrapping the path in quotation marks is the safest approach
-        with run_context.prefix(f'cd "{custom_working_dir}"'):
+        flag = ""
+        if platform.system() == "Windows":
+            flag = "/d"
+        with run_context.prefix(f'cd {flag} "{custom_working_dir}"'):
             return run_context.run(cli_full_line, echo=False, hide=True, warn=True, env=env)
 
     return _run
@@ -130,7 +133,10 @@ def daemon_runner(pytestconfig, data_dir, downloads_dir, working_dir):
     # Context.cd() is not used since it doesn't work correctly on Windows.
     # It escapes spaces in the path using "\ " but it doesn't always work,
     # wrapping the path in quotation marks is the safest approach
-    run_context.prefix(f'cd "{working_dir}"')
+    flag = ""
+    if platform.system() == "Windows":
+        flag = "/d"
+    run_context.prefix(f'cd {flag} "{working_dir}"')
     # Local Class is the implementation of a Runner abstract class
     runner = Local(run_context)
     runner.run(cli_full_line, echo=False, hide=True, warn=True, env=env, asynchronous=True)

Diff for: test/test_archive.py

@@ -56,7 +56,6 @@ def _run(cmd_string, custom_working_dir):
     return _run
 
 
-@pytest.mark.skip()
 def test_archive_no_args(run_simple, run_command, copy_sketch, working_dir):
     # result = run_simple("dir", copy_sketch)
     # print(result.stdout)
@@ -86,7 +85,6 @@ def test_archive_no_args(run_simple, run_command, copy_sketch, working_dir):
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_dot_arg(run_command, copy_sketch, working_dir):
     result = run_command("archive .", copy_sketch)
     assert result.ok
@@ -111,7 +109,6 @@ def test_archive_dot_arg(run_command, copy_sketch, working_dir):
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_dot_arg_relative_zip_path(run_command, copy_sketch, working_dir):
     # Creates a folder where to save the zip
     archives_folder = f"{working_dir}/my_archives/"
@@ -140,7 +137,6 @@ def test_archive_dot_arg_relative_zip_path(run_command, copy_sketch, working_dir
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_dot_arg_absolute_zip_path(run_command, copy_sketch, working_dir):
     # Creates a folder where to save the zip
     archives_folder = f"{working_dir}/my_archives/"
@@ -170,7 +166,6 @@ def test_archive_dot_arg_absolute_zip_path(run_command, copy_sketch, working_dir
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_dot_arg_relative_zip_path_and_name_without_extension(run_command, copy_sketch, working_dir):
     # Creates a folder where to save the zip
     archives_folder = f"{working_dir}/my_archives/"
@@ -199,7 +194,6 @@ def test_archive_dot_arg_relative_zip_path_and_name_without_extension(run_comman
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_dot_arg_absolute_zip_path_and_name_without_extension(run_command, copy_sketch, working_dir):
     # Creates a folder where to save the zip
     archives_folder = f"{working_dir}/my_archives/"
@@ -228,7 +222,6 @@ def test_archive_dot_arg_absolute_zip_path_and_name_without_extension(run_comman
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_dot_arg_custom_zip_path_and_name_with_extension(run_command, copy_sketch, working_dir):
     # Creates a folder where to save the zip
     archives_folder = f"{working_dir}/my_archives/"
@@ -257,7 +250,6 @@ def test_archive_dot_arg_custom_zip_path_and_name_with_extension(run_command, co
     archive.close()
 
 
-@pytest.mark.skip()
 def test_archive_relative_sketch_path(run_command, copy_sketch, working_dir):
     result = run_command("archive ./sketch_simple")
     assert result.ok