Skip to content

Commit f4a55e6

Browse files
authored
add fqbn flag for board details command (#895)
* add fqbn flag for `board details` command
1 parent 385016c commit f4a55e6

File tree

4 files changed

+110
-63
lines changed

4 files changed

+110
-63
lines changed

Diff for: cli/board/details.go

+12-4
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,21 @@ import (
3333

3434
var tr = i18n.Tr
3535
var showFullDetails bool
36+
var fqbn string
3637

3738
func initDetailsCommand() *cobra.Command {
3839
var detailsCommand = &cobra.Command{
39-
Use: "details <FQBN>",
40+
Use: "details -b <FQBN>",
4041
Short: tr("Print details about a board."),
4142
Long: tr("Show information about a board, in particular if the board has options to be specified in the FQBN."),
42-
Example: " " + os.Args[0] + " board details arduino:avr:nano",
43-
Args: cobra.ExactArgs(1),
43+
Example: " " + os.Args[0] + " board details -b arduino:avr:nano",
44+
Args: cobra.MaximumNArgs(1),
4445
Run: runDetailsCommand,
4546
}
4647

4748
detailsCommand.Flags().BoolVarP(&showFullDetails, "full", "f", false, tr("Show full board details"))
49+
detailsCommand.Flags().StringVarP(&fqbn, "fqbn", "b", "", "Fully Qualified Board Name, e.g.: arduino:avr:uno")
50+
// detailsCommand.MarkFlagRequired("fqbn") // enable once `board details <fqbn>` is removed
4851

4952
return detailsCommand
5053
}
@@ -56,9 +59,14 @@ func runDetailsCommand(cmd *cobra.Command, args []string) {
5659
os.Exit(errorcodes.ErrGeneric)
5760
}
5861

62+
// remove once `board details <fqbn>` is removed
63+
if fqbn == "" && len(args) > 0 {
64+
fqbn = args[0]
65+
}
66+
5967
res, err := board.Details(context.Background(), &rpc.BoardDetailsReq{
6068
Instance: inst,
61-
Fqbn: args[0],
69+
Fqbn: fqbn,
6270
})
6371

6472
if err != nil {

Diff for: i18n/data/en.po

+27-27
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,28 @@ msgstr "Aliases:"
1313
msgid "Available Commands:"
1414
msgstr "Available Commands:"
1515

16-
#: cli/board/details.go:98
16+
#: cli/board/details.go:106
1717
msgid "Board name:"
1818
msgstr "Board name:"
1919

20-
#: cli/board/details.go:100
20+
#: cli/board/details.go:108
2121
msgid "Board version:"
2222
msgstr "Board version:"
2323

24-
#: cli/board/details.go:141
24+
#: cli/board/details.go:149
2525
msgid "Checksum:"
2626
msgstr "Checksum:"
2727

28-
#: cli/board/details.go:55
29-
#: cli/board/details.go:65
28+
#: cli/board/details.go:58
29+
#: cli/board/details.go:73
3030
msgid "Error getting board details: %v"
3131
msgstr "Error getting board details: %v"
3232

3333
#: cli/usage.go:27
3434
msgid "Examples:"
3535
msgstr "Examples:"
3636

37-
#: cli/board/details.go:139
37+
#: cli/board/details.go:147
3838
msgid "File:"
3939
msgstr "File:"
4040

@@ -46,87 +46,87 @@ msgstr "Flags:"
4646
msgid "Global Flags:"
4747
msgstr "Global Flags:"
4848

49-
#: cli/board/details.go:111
49+
#: cli/board/details.go:119
5050
msgid "Identification properties:"
5151
msgstr "Identification properties:"
5252

53-
#: cli/board/details.go:138
53+
#: cli/board/details.go:146
5454
msgid "OS:"
5555
msgstr "OS:"
5656

57-
#: cli/board/details.go:104
57+
#: cli/board/details.go:112
5858
msgid "Official Arduino board:"
5959
msgstr "Official Arduino board:"
6060

61-
#: cli/board/details.go:150
61+
#: cli/board/details.go:158
6262
msgid "Option:"
6363
msgstr "Option:"
6464

65-
#: cli/board/details.go:120
65+
#: cli/board/details.go:128
6666
msgid "Package URL:"
6767
msgstr "Package URL:"
6868

69-
#: cli/board/details.go:119
69+
#: cli/board/details.go:127
7070
msgid "Package maintainer:"
7171
msgstr "Package maintainer:"
7272

73-
#: cli/board/details.go:118
73+
#: cli/board/details.go:126
7474
msgid "Package name:"
7575
msgstr "Package name:"
7676

77-
#: cli/board/details.go:122
77+
#: cli/board/details.go:130
7878
msgid "Package online help:"
7979
msgstr "Package online help:"
8080

81-
#: cli/board/details.go:121
81+
#: cli/board/details.go:129
8282
msgid "Package website:"
8383
msgstr "Package website:"
8484

85-
#: cli/board/details.go:128
85+
#: cli/board/details.go:136
8686
msgid "Platform URL:"
8787
msgstr "Platform URL:"
8888

89-
#: cli/board/details.go:127
89+
#: cli/board/details.go:135
9090
msgid "Platform architecture:"
9191
msgstr "Platform architecture:"
9292

93-
#: cli/board/details.go:126
93+
#: cli/board/details.go:134
9494
msgid "Platform category:"
9595
msgstr "Platform category:"
9696

97-
#: cli/board/details.go:131
97+
#: cli/board/details.go:139
9898
msgid "Platform checksum:"
9999
msgstr "Platform checksum:"
100100

101-
#: cli/board/details.go:129
101+
#: cli/board/details.go:137
102102
msgid "Platform file name:"
103103
msgstr "Platform file name:"
104104

105-
#: cli/board/details.go:125
105+
#: cli/board/details.go:133
106106
msgid "Platform name:"
107107
msgstr "Platform name:"
108108

109-
#: cli/board/details.go:130
109+
#: cli/board/details.go:138
110110
msgid "Platform size (bytes):"
111111
msgstr "Platform size (bytes):"
112112

113-
#: cli/board/details.go:40
113+
#: cli/board/details.go:41
114114
msgid "Print details about a board."
115115
msgstr "Print details about a board."
116116

117-
#: cli/board/details.go:135
117+
#: cli/board/details.go:143
118118
msgid "Required tool:"
119119
msgstr "Required tool:"
120120

121-
#: cli/board/details.go:47
121+
#: cli/board/details.go:48
122122
msgid "Show full board details"
123123
msgstr "Show full board details"
124124

125-
#: cli/board/details.go:41
125+
#: cli/board/details.go:42
126126
msgid "Show information about a board, in particular if the board has options to be specified in the FQBN."
127127
msgstr "Show information about a board, in particular if the board has options to be specified in the FQBN."
128128

129-
#: cli/board/details.go:140
129+
#: cli/board/details.go:148
130130
msgid "Size (bytes):"
131131
msgstr "Size (bytes):"
132132

Diff for: i18n/rice-box.go

+8-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)