Pluggable discovery upload user fields are now limited to 50 chars

Author: silvanocerza

commands/upload/upload.go

@@ -102,6 +102,9 @@ func getUserFields(toolID string, platformRelease *cores.PlatformRelease) ([]*rp
 
 	for _, key := range keys {
 		value := fields.Get(key)
+		if len(value) > 50 {
+			value = fmt.Sprintf("%s…", value[:49])
+		}
 		secretProp := fmt.Sprintf("%s.secret", key)
 		secret, ok := fields.GetOk(secretProp)
 		if !ok {

commands/upload/upload_test.go

@@ -303,4 +303,17 @@ tools.arduino_ota.upload.field.password.secret=THIS_IS_NOT_A_BOOLEAN`))
 	userFields, err = getUserFields("arduino_ota", platformRelease)
 	require.Nil(t, userFields)
 	require.EqualError(t, err, `parsing "tools.arduino_ota.upload.field.password.secret", property is not a boolean`)
+
+	props, err = properties.LoadFromBytes([]byte(`
+tools.arduino_ota.upload.field.some_field=This is a really long label that ideally must never be set by any platform
+`))
+	require.NoError(t, err)
+	platformRelease.Properties = props
+	userFields, err = getUserFields("arduino_ota", platformRelease)
+	require.NoError(t, err)
+	require.Len(t, userFields, 1)
+	require.Equal(t, userFields[0].ToolId, "arduino_ota")
+	require.Equal(t, userFields[0].Name, "some_field")
+	require.Equal(t, userFields[0].Label, "This is a really long label that ideally must nev…")
+	require.False(t, userFields[0].Secret)
 }

docs/platform-specification.md

@@ -972,6 +972,19 @@ tools.arduino_ota.upload.field.password.secret=true
 tools.arduino_ota.upload.pattern="{runtime.tools.arduinoOTA.path}/bin/arduinoOTA" -address {upload.port.address} -port 65280 -username "{upload.field.username} -password "{upload.field.password}" -sketch "{build.path}/{build.project_name}.bin"
 ```
 
+If a **FIELD_LABEL** is longer than 50 characters it will be truncated to 49 characters and an ellipsis (`…`) appended
+to it. For example this field:
+
+```
+tools.arduino_ota.upload.field.some_field=This is a really long label that ideally must never be set by any platform
+```
+
+will be shown to the user as:
+
+```
+This is a really long label that ideally must nev…
+```
+
 #### Upload verification
 
 Upload verification can be enabled via the Arduino IDE's **File > Preferences > Verify code after upload** or