Disable logging immediately

By default, logging is disabled, but this was previously done in configuration.Initialize(), meaning that any log output
above the default level made before that part of the configuration ran was still displayed.

Author: per1234

configuration/configuration.go

@@ -18,6 +18,7 @@ package configuration
 
 import (
 	"fmt"
+	"io/ioutil"
 	"os"
 	"strconv"
 	"strings"
@@ -56,15 +57,13 @@ func Initialize(flags *pflag.FlagSet, projectPaths []string) error {
 		}
 	}
 
-	logrus.SetOutput(defaultLogOutput)
-
 	if logFormatString, ok := os.LookupEnv("ARDUINO_CHECK_LOG_FORMAT"); ok {
 		logFormat, err := logFormatFromString(logFormatString)
 		if err != nil {
 			return fmt.Errorf("--log-format flag value %s not valid", logFormatString)
 		}
 		logrus.SetFormatter(logFormat)
-		logrus.SetOutput(os.Stderr) // Enable log output.
+		EnableLogging(true)
 	}
 
 	if logLevelString, ok := os.LookupEnv("ARDUINO_CHECK_LOG_LEVEL"); ok {
@@ -73,7 +72,7 @@ func Initialize(flags *pflag.FlagSet, projectPaths []string) error {
 			return fmt.Errorf("--log-level flag value %s not valid", logLevelString)
 		}
 		logrus.SetLevel(logLevel)
-		logrus.SetOutput(os.Stderr) // Enable log output.
+		EnableLogging(true)
 	}
 
 	superprojectTypeFilterString, _ := flags.GetString("project-type")
@@ -232,3 +231,11 @@ func SchemasPath() *paths.Path {
 	}
 	return paths.New(executablePath).Parent().Join("etc", "schemas")
 }
+
+func EnableLogging(enable bool) {
+	if enable {
+		logrus.SetOutput(defaultLogOutput) // Enable log output.
+	} else {
+		logrus.SetOutput(ioutil.Discard)
+	}
+}

configuration/defaults.go

@@ -18,7 +18,7 @@ package configuration
 // The default configuration settings.
 
 import (
-	"io/ioutil"
+	"os"
 
 	"github.com/arduino/arduino-check/configuration/checkmode"
 	"github.com/arduino/arduino-check/project/projecttype"
@@ -61,4 +61,4 @@ var defaultCheckModes = map[projecttype.Type]map[checkmode.Type]bool{
 	},
 }
 
-var defaultLogOutput = ioutil.Discard // Default to no log output.
+var defaultLogOutput = os.Stderr

main.go

@@ -19,9 +19,14 @@ import (
 	"os"
 
 	"github.com/arduino/arduino-check/cli"
+	"github.com/arduino/arduino-check/configuration"
 	"github.com/arduino/arduino-check/result/feedback"
 )
 
+func init() {
+	configuration.EnableLogging(false)
+}
+
 func main() {
 	rootCommand := cli.Root()
 	if err := rootCommand.Execute(); err != nil {