Skip to content

Commit e459aab

Browse files
wip debug go-git on win
1 parent bd418ce commit e459aab

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Diff for: .github/workflows/test-go-task.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
id: collection
7373
# jq flags must be "-cRn" see: https://stackoverflow.com/a/68859958/1655275
7474
run: |
75-
echo "tests-data=$(go list ./internal/integrationtest/... | grep integrationtest/ | tr "/" " " | cut -d " " -f 6 | jq -cRn '[inputs]')" >> $GITHUB_OUTPUT
75+
echo "tests-data=$(go list ./internal/integrationtest/... | grep integrationtest/ | tr "/" " " | cut -d " " -f 6 | grep lib | jq -cRn '[inputs]')" >> $GITHUB_OUTPUT
7676
7777
test-integration:
7878
needs: tests-collector

Diff for: Taskfile.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ tasks:
119119
-v \
120120
-short \
121121
{{ .GO_TEST_PACKAGE }} \
122-
-run '{{default ".*" .GO_TEST_REGEX}}' \
122+
-run '^TestInstallWithGitUrlFragmentAsBranch$' \
123123
{{default "-timeout 20m -coverpkg=./... -covermode=atomic" .GO_TEST_FLAGS}} \
124124
-coverprofile=coverage_unit.txt \
125125
{{default .DEFAULT_INTEGRATIONTEST_GO_PACKAGES .GO_PACKAGES}} \

Diff for: internal/arduino/libraries/librariesmanager/install.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,11 @@ func (lmi *Installer) InstallGitLib(argURL string, overwrite bool) error {
208208
}
209209

210210
// Clone library in a temporary directory
211-
tmp, err := paths.MkTempDir("", "")
211+
tmp, err := paths.MkTempDir("", "arduino-cli-lib")
212212
if err != nil {
213213
return err
214214
}
215-
defer tmp.RemoveAll()
215+
// defer tmp.RemoveAll()
216216
tmpInstallPath := tmp.Join(libraryName)
217217

218218
depth := 1
@@ -239,7 +239,7 @@ func (lmi *Installer) InstallGitLib(argURL string, overwrite bool) error {
239239
}
240240

241241
// We don't want the installed library to be a git repository thus we delete this folder
242-
tmpInstallPath.Join(".git").RemoveAll()
242+
// tmpInstallPath.Join(".git").RemoveAll()
243243

244244
// Install extracted library in the destination directory
245245
if err := lmi.importLibraryFromDirectory(tmpInstallPath, overwrite); err != nil {

0 commit comments

Comments
 (0)