feat: specialize init errors

Author: Luca Bianconi

arduino/errors.go

@@ -308,6 +308,36 @@ func (e *ProgrammerRequiredForUploadError) ToRPCStatus() *status.Status {
 	return st
 }
 
+type FailedInstanceInitReason string
+
+const (
+	Unspecified     FailedInstanceInitReason = "UNSPECIFIED"
+	InvalidIndexURL FailedInstanceInitReason = "INVALID_INDEX_URL"
+	ErrorIndexLoad  FailedInstanceInitReason = "INDEX_LOAD_ERROR"
+	ErrorToolLoad   FailedInstanceInitReason = "TOOL_LOAD_ERROR"
+)
+
+type ErrorInitFailed struct {
+	Code   codes.Code
+	Cause  error
+	Reason FailedInstanceInitReason
+}
+
+func (ife *ErrorInitFailed) Error() string {
+	return ife.Cause.Error()
+}
+
+// ToRPCStatus converts the error into a *status.Status
+func (ife *ErrorInitFailed) ToRPCStatus() *status.Status {
+	st, _ := status.
+		New(ife.Code, ife.Cause.Error()).
+		WithDetails(&rpc.FailedInstanceInitError{
+			Reason:  string(ife.Reason),
+			Message: ife.Cause.Error(),
+		})
+	return st
+}
+
 // ProgrammerNotFoundError is returned when the programmer is not found
 type ProgrammerNotFoundError struct {
 	Programmer string
@@ -405,7 +435,9 @@ func (e *PlatformLoadingError) Error() string {
 
 // ToRPCStatus converts the error into a *status.Status
 func (e *PlatformLoadingError) ToRPCStatus() *status.Status {
-	return status.New(codes.FailedPrecondition, e.Error())
+	s, _ := status.New(codes.FailedPrecondition, e.Error()).
+		WithDetails(&rpc.PlatformLoadingError{})
+	return s
 }
 
 func (e *PlatformLoadingError) Unwrap() error {

commands/instances.go

@@ -303,23 +303,35 @@ func Init(req *rpc.InitRequest, responseCallback func(r *rpc.InitResponse)) erro
 		for _, u := range urls {
 			URL, err := utils.URLParse(u)
 			if err != nil {
-				s := status.Newf(codes.InvalidArgument, tr("Invalid additional URL: %v"), err)
-				responseError(s)
+				e := &arduino.ErrorInitFailed{
+					Code:   codes.InvalidArgument,
+					Cause:  fmt.Errorf(tr("Invalid additional URL: %v", err)),
+					Reason: arduino.InvalidIndexURL,
+				}
+				responseError(e.ToRPCStatus())
 				continue
 			}
 
 			if URL.Scheme == "file" {
 				_, err := pmb.LoadPackageIndexFromFile(paths.New(URL.Path))
 				if err != nil {
-					s := status.Newf(codes.FailedPrecondition, tr("Loading index file: %v"), err)
-					responseError(s)
+					e := &arduino.ErrorInitFailed{
+						Code:   codes.FailedPrecondition,
+						Cause:  fmt.Errorf(tr("Loading index file: %v", err)),
+						Reason: arduino.ErrorIndexLoad,
+					}
+					responseError(e.ToRPCStatus())
 				}
 				continue
 			}
 
 			if err := pmb.LoadPackageIndex(URL); err != nil {
-				s := status.Newf(codes.FailedPrecondition, tr("Loading index file: %v"), err)
-				responseError(s)
+				e := &arduino.ErrorInitFailed{
+					Code:   codes.FailedPrecondition,
+					Cause:  fmt.Errorf(tr("Loading index file: %v", err)),
+					Reason: arduino.ErrorIndexLoad,
+				}
+				responseError(e.ToRPCStatus())
 			}
 		}
 
@@ -331,8 +343,12 @@ func Init(req *rpc.InitRequest, responseCallback func(r *rpc.InitResponse)) erro
 		for name, tool := range pmb.GetOrCreatePackage("builtin").Tools {
 			latest := tool.LatestRelease()
 			if latest == nil {
-				s := status.Newf(codes.Internal, tr("can't find latest release of tool %s", name))
-				responseError(s)
+				e := &arduino.ErrorInitFailed{
+					Code:   codes.Internal,
+					Cause:  fmt.Errorf(tr("can't find latest release of tool %s", name)),
+					Reason: arduino.ErrorToolLoad,
+				}
+				responseError(e.ToRPCStatus())
 			} else if !latest.IsInstalled() {
 				builtinToolsToInstall = append(builtinToolsToInstall, latest)
 			}
@@ -342,8 +358,12 @@ func Init(req *rpc.InitRequest, responseCallback func(r *rpc.InitResponse)) erro
 		if len(builtinToolsToInstall) > 0 {
 			for _, toolRelease := range builtinToolsToInstall {
 				if err := installTool(pmb.Build(), toolRelease, downloadCallback, taskCallback); err != nil {
-					s := status.Newf(codes.Internal, err.Error())
-					responseError(s)
+					e := &arduino.ErrorInitFailed{
+						Code:   codes.Internal,
+						Cause:  err,
+						Reason: arduino.ErrorToolLoad,
+					}
+					responseError(e.ToRPCStatus())
 				}
 			}
 

rpc/cc/arduino/cli/commands/v1/commands.pb.go

@@ -209,6 +209,13 @@ message InitResponse {
   }
 }
 
+message FailedInstanceInitError {
+    // specific cause of the error
+    string reason = 1;
+    // explanation of the error
+    string message = 2;
+}
+
 message DestroyRequest {
   // The Arduino Core Service instance to destroy.
   Instance instance = 1;

rpc/cc/arduino/cli/commands/v1/commands.proto

@@ -45,6 +45,8 @@ message PlatformInstallResponse {
   TaskProgress task_progress = 2;
 }
 
+message PlatformLoadingError {}
+
 message PlatformDownloadRequest {
   // Arduino Core Service instance from the `Init` response.
   Instance instance = 1;