Add check for .development flag file in library

Author: per1234

Diff for: check/checkconfigurations/checkconfigurations.go

@@ -821,6 +821,21 @@ var configurations = []Type{
 		ErrorModes:      []checkmode.Type{checkmode.LibraryManagerSubmission, checkmode.LibraryManagerIndexed},
 		CheckFunction:   checkfunctions.LibraryContainsSymlinks,
 	},
+	{
+		ProjectType:     projecttype.Library,
+		Category:        "structure",
+		Subcategory:     "",
+		ID:              "",
+		Brief:           ".development file",
+		Description:     "",
+		MessageTemplate: ".development flag file found. Presence of this file blocks addition to the Library Manager index.",
+		DisableModes:    nil,
+		EnableModes:     []checkmode.Type{checkmode.All},
+		InfoModes:       nil,
+		WarningModes:    []checkmode.Type{checkmode.Default},
+		ErrorModes:      []checkmode.Type{checkmode.LibraryManagerSubmission, checkmode.LibraryManagerIndexed},
+		CheckFunction:   checkfunctions.LibraryHasDotDevelopmentFile,
+	},
 	{
 		ProjectType:     projecttype.Sketch,
 		Category:        "structure",

Diff for: check/checkfunctions/library.go

@@ -892,6 +892,21 @@ func LibraryContainsSymlinks() (result checkresult.Type, output string) {
 	return checkresult.Pass, ""
 }
 
+// LibraryHasDotDevelopmentFile checks whether the library contains a .development flag file.
+func LibraryHasDotDevelopmentFile() (result checkresult.Type, output string) {
+	dotDevelopmentPath := checkdata.ProjectPath().Join(".development")
+	hasDotDevelopment, err := dotDevelopmentPath.ExistCheck()
+	if err != nil {
+		panic(err)
+	}
+
+	if hasDotDevelopment && dotDevelopmentPath.IsNotDir() {
+		return checkresult.Fail, ""
+	}
+
+	return checkresult.Pass, ""
+}
+
 // spellCheckLibraryPropertiesFieldValue returns the value of the provided library.properties field with commonly misspelled words corrected.
 func spellCheckLibraryPropertiesFieldValue(fieldName string) (result checkresult.Type, output string) {
 	if checkdata.LibraryPropertiesLoadError() != nil {

Diff for: check/checkfunctions/library_test.go

@@ -225,3 +225,12 @@ func TestLibraryContainsSymlinks(t *testing.T) {
 
 	checkCheckFunction(LibraryContainsSymlinks, testTables, t)
 }
+
+func TestLibraryHasDotDevelopmentFile(t *testing.T) {
+	testTables := []checkFunctionTestTable{
+		{"Has .development file", "DotDevelopment", checkresult.Fail, ""},
+		{"No .development file", "Recursive", checkresult.Pass, ""},
+	}
+
+	checkCheckFunction(LibraryHasDotDevelopmentFile, testTables, t)
+}

Diff for: check/checkfunctions/testdata/libraries/DotDevelopment/.development

@@ -0,0 +1,9 @@
+name=DotDevelopment
+version=1.0.0
+author=Cristian Maglie <[email protected]>, Pippo Pluto <[email protected]>
+maintainer=Cristian Maglie <[email protected]>
+sentence=A library that makes coding a web server a breeze.
+paragraph=Supports HTTP1.1 and you can do GET and POST.
+category=Communication
+url=http://example.com/
+architectures=avr