Skip to content

Commit de90579

Browse files
authored
Disable "fail fast" feature in "Test Go" workflow (#2014)
For efficiency, the "Test Go" GitHub Actions workflow splits the test suite into multiple jobs which run in parallel. This is done via a "job matrix". By default GitHub Actions uses a "fail fast" behavior for job matrixes, where all in progress or pending jobs of the matrix are immediately canceled upon failure of any job. The benefit of this "fail fast" behavior is efficiency in the case where a failure is universal and those other jobs were certain to eventually fail. However, in other cases a failure is either specific to the configuration of a single job (e.g., a Windows-specific bug), or a spurious result of a transient network outage. In the latter case, canceling the other jobs is very harmful. Running the jobs for the other operating systems would highlight the nature of an OS-specific failure for the contributor. Canceling other jobs due to a transient failure means all those jobs must be reran instead of only the specific job that suffered the failure. The workflow is hereby configured to disable the "fail fast" behavior. All the matrix jobs will now run even if one of them has failed.
1 parent 62b4493 commit de90579

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: .github/workflows/test-go-task.yml

+2
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ jobs:
7676
test-integration:
7777
needs: tests-collector
7878
strategy:
79+
fail-fast: false
7980
matrix:
8081
operating-system:
8182
- ubuntu-latest
@@ -113,6 +114,7 @@ jobs:
113114
test:
114115
needs: run-determination
115116
strategy:
117+
fail-fast: false
116118
matrix:
117119
operating-system:
118120
- ubuntu-latest

0 commit comments

Comments
 (0)