if one of the args failed, exit with an error code

masci · masci · commit dcc1d2f5f689 · 2019-07-18T17:38:59.000+02:00
diff --git a/cli/core/upgrade.go b/cli/core/upgrade.go
@@ -71,10 +71,12 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) {
 	}
 
 	// proceed upgrading, if anything is upgradable
+	exitErr := false
 	platformsRefs := parsePlatformReferenceArgs(args)
 	for i, platformRef := range platformsRefs {
 		if platformRef.Version != "" {
 			formatter.PrintErrorMessage(("Invalid item " + args[i]))
+			exitErr = true
 			continue
 		}
 
@@ -92,4 +94,8 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) {
 			os.Exit(errorcodes.ErrGeneric)
 		}
 	}
+
+	if exitErr {
+		os.Exit(errorcodes.ErrBadArgument)
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,12 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`// proceed upgrading, if anything is upgradable`
	`74`	`+ exitErr := false`
`74`	`75`	`platformsRefs := parsePlatformReferenceArgs(args)`
`75`	`76`	`for i, platformRef := range platformsRefs {`
`76`	`77`	`if platformRef.Version != "" {`
`77`	`78`	`formatter.PrintErrorMessage(("Invalid item " + args[i]))`
	`79`	`+ exitErr = true`
`78`	`80`	`continue`
`79`	`81`	`}`
`80`	`82`
`@@ -92,4 +94,8 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) {`
`92`	`94`	`os.Exit(errorcodes.ErrGeneric)`
`93`	`95`	`}`
`94`	`96`	`}`
	`97`	`+`
	`98`	`+ if exitErr {`
	`99`	`+ os.Exit(errorcodes.ErrBadArgument)`
	`100`	`+ }`
`95`	`101`	`}`