Skip to content

Commit d232f3c

Browse files
Massimiliano Pippimasci
Massimiliano Pippi
authored andcommitted
docs + dont run go tests anymore
1 parent 34114c6 commit d232f3c

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

Diff for: CONTRIBUTING.md

+5-7
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ see following paragraph):
6060
task test-integration
6161
```
6262
### Running only some tests
63+
6364
By default, all tests from all go packages are run. To run only unit
6465
tests from one or more specific packages, you can set the TARGETS
6566
environment variable, e.g.:
@@ -75,11 +76,6 @@ Both can be combined as well, typically to run only a specific test:
7576

7677
TEST_REGEX='^TestFindBoardWithFQBN$' TARGETS=./arduino/cores/packagemanager task test-unit
7778

78-
For integration test, the same options are supported. Note that when not
79-
specified, `TEST_REGEX` defaults to "Integration" to select only
80-
integration tests, so if you specify a broader regex, this could cause
81-
non-integration tests to be run as well.
82-
8379
### Integration tests
8480

8581
Being a command line interface, Arduino CLI is heavily interactive and it has to
@@ -95,7 +91,8 @@ assess the options are correctly understood and the output is what we expect.
9591
To run the full suite of integration tests you need an Arduino device attached
9692
to a serial port and a working Python environment. Chances are that you already
9793
have Python installed in your system, if this is not the case you can
98-
[download][3] the official distribution or use the package manager provided by your Operating System.
94+
[download][3] the official distribution or use the package manager provided by
95+
your Operating System.
9996

10097
Some dependencies need to be installed before running the tests and to avoid
10198
polluting your global Python enviroment with dependencies that might be only
@@ -151,7 +148,8 @@ a list of items you can check before submitting a PR:
151148
* Maintain **clean commit history** and use **meaningful commit messages**.
152149
PRs with messy commit history are difficult to review and require a lot of
153150
work to be merged.
154-
* Your PR must pass all CI tests before we will merge it. If you're seeing an error and don't think
151+
* Your PR must pass all CI tests before we will merge it. If you're seeing an
152+
error and don't think
155153
it's your fault, it may not be! The reviewer will help you if there are test
156154
failures that seem
157155
not related to the change you are making.

Diff for: Taskfile.yml

-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ tasks:
2727
test-integration:
2828
desc: Run integration tests only
2929
cmds:
30-
- go test -run '{{ default "Integration" .TEST_REGEX }}' {{ default "-v" .GOFLAGS }} -coverprofile=coverage_integ.txt {{ default .DEFAULT_TARGETS .TARGETS }} {{.TEST_LDFLAGS}}
3130
- pytest test
3231

3332
test-legacy:

Diff for: test/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Integration tests
22

3-
This dir contains integration tests, the aim is to test the Command Line Interface and its output
4-
from a pure user point of view.
3+
This dir contains integration tests, aimed to test the Command Line Interface
4+
and its output from a pure user point of view.
55

66
## Installation
77

Diff for: test/test_compile.py

+3
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@ def test_compile_with_simple_sketch(run_command, data_dir, working_dir):
9090
)
9191
)
9292
assert result.ok
93+
print(os.listdir(working_dir))
94+
print(result.stdout)
95+
print(result.stderr)
9396
assert os.path.exists(os.path.join(working_dir, "test.hex"))
9497

9598
# Test extention won't be added if already present

0 commit comments

Comments
 (0)