Migrated TestBoardListall from test_board.py to board_test.go

Author: MatteoPologruto

Diff for: internal/integrationtest/board/board_test.go

@@ -79,3 +79,49 @@ func TestBoardListWithInvalidDiscovery(t *testing.T) {
 	require.NoError(t, err)
 	require.Contains(t, string(stdout), "builtin:serial-discovery")
 }
+
+func TestBoardListall(t *testing.T) {
+	env := testsuite.NewEnvironment(t)
+	defer env.CleanUp()
+
+	cli := integrationtest.NewArduinoCliWithinEnvironment(env, &integrationtest.ArduinoCLIConfig{
+		ArduinoCLIPath:         paths.New("..", "..", "..", "arduino-cli"),
+		UseSharedStagingFolder: true,
+	})
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "install", "arduino:[email protected]")
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("board", "listall", "--format", "json")
+	require.NoError(t, err)
+	var data map[string]interface{}
+	err = json.Unmarshal(stdout, &data)
+	require.NoError(t, err)
+
+	// maps each json contained in "boards" using
+	// its corresponding "fqbn" value as its key
+	boards := make(map[string]map[string]interface{})
+	for _, v := range data["boards"].([]interface{}) {
+		mapV := v.(map[string]interface{})
+		boards[mapV["fqbn"].(string)] = mapV
+	}
+	require.Len(t, boards, 26)
+
+	require.Contains(t, boards, "arduino:avr:yun")
+	require.Equal(t, boards["arduino:avr:yun"]["name"], "Arduino Yún")
+	platform := boards["arduino:avr:yun"]["platform"].(map[string]interface{})
+	require.Equal(t, platform["id"], "arduino:avr")
+	require.Equal(t, platform["installed"], "1.8.3")
+	require.NotEmpty(t, platform["latest"])
+	require.Equal(t, platform["name"], "Arduino AVR Boards")
+
+	require.Contains(t, boards, "arduino:avr:uno")
+	require.Equal(t, boards["arduino:avr:uno"]["name"], "Arduino Uno")
+	platform = boards["arduino:avr:uno"]["platform"].(map[string]interface{})
+	require.Equal(t, platform["id"], "arduino:avr")
+	require.Equal(t, platform["installed"], "1.8.3")
+	require.NotEmpty(t, platform["latest"])
+	require.Equal(t, platform["name"], "Arduino AVR Boards")
+}

Diff for: test/test_board.py

@@ -394,31 +394,6 @@
 """  # noqa: E501
 
 
-def test_board_listall(run_command):
-    assert run_command(["update"])
-    assert run_command(["core", "install", "arduino:[email protected]"])
-    res = run_command(["board", "listall", "--format", "json"])
-    assert res.ok
-    data = json.loads(res.stdout)
-    boards = {b["fqbn"]: b for b in data["boards"]}
-    assert len(boards) == 26
-    assert "arduino:avr:yun" in boards
-    assert "Arduino Yún" == boards["arduino:avr:yun"]["name"]
-    platform = boards["arduino:avr:yun"]["platform"]
-    assert "arduino:avr" == platform["id"]
-    assert "1.8.3" == platform["installed"]
-    assert "" != platform["latest"]
-    assert "Arduino AVR Boards" == platform["name"]
-
-    assert "arduino:avr:uno" in boards
-    assert "Arduino Uno" == boards["arduino:avr:uno"]["name"]
-    platform = boards["arduino:avr:uno"]["platform"]
-    assert "arduino:avr" == platform["id"]
-    assert "1.8.3" == platform["installed"]
-    assert "" != platform["latest"]
-    assert "Arduino AVR Boards" == platform["name"]
-
-
 def test_board_listall_with_manually_installed_platform(run_command, data_dir):
     assert run_command(["update"])