Removed all wrong accesses to package Explorer

Author: cmaglie

Diff for: internal/cli/arguments/completion.go

@@ -20,7 +20,6 @@ import (
 
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/commands/core"
-	"github.com/arduino/arduino-cli/commands/internal/instances"
 	"github.com/arduino/arduino-cli/commands/lib"
 	"github.com/arduino/arduino-cli/commands/upload"
 	"github.com/arduino/arduino-cli/internal/cli/instance"
@@ -51,13 +50,6 @@ func GetInstalledBoards() []string {
 func GetInstalledProtocols() []string {
 	inst := instance.CreateAndInit()
 
-	// FIXME: We must not access PackageManager directly here but use one of the commands.* functions
-	pme, release := instances.GetPackageManagerExplorer(inst)
-	if pme == nil {
-		return nil // should never happen...
-	}
-	defer release()
-
 	boards := pme.InstalledBoards()
 
 	installedProtocols := make(map[string]struct{})
@@ -94,13 +86,6 @@ func GetInstalledProgrammers() []string {
 	}
 	list, _ := board.ListAll(context.Background(), listAllReq)
 
-	// FIXME: We must not access PackageManager directly here but use one of the commands.* functions
-	pme, release := instances.GetPackageManagerExplorer(inst)
-	if pme == nil {
-		return nil // should never happen...
-	}
-	defer release()
-
 	installedProgrammers := make(map[string]string)
 	for _, board := range list.Boards {
 		programmers, _ := upload.ListProgrammersAvailableForUpload(context.Background(), &rpc.ListProgrammersAvailableForUploadRequest{

Diff for: internal/cli/arguments/port.go

@@ -21,7 +21,6 @@ import (
 
 	"github.com/arduino/arduino-cli/arduino"
 	"github.com/arduino/arduino-cli/commands/board"
-	"github.com/arduino/arduino-cli/commands/internal/instances"
 	"github.com/arduino/arduino-cli/internal/cli/feedback"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 	"github.com/sirupsen/logrus"
@@ -88,13 +87,6 @@ func (p *Port) GetPort(instance *rpc.Instance, defaultAddress, defaultProtocol s
 	}
 	logrus.WithField("port", address).Tracef("Upload port")
 
-	// FIXME: We must not access PackageManager directly here but use one of the commands.* functions
-	pme, release := instances.GetPackageManagerExplorer(instance)
-	if pme == nil {
-		return nil, &arduino.InvalidInstanceError{}
-	}
-	defer release()
-
 	dm := pme.DiscoveryManager()
 	watcher, err := dm.Watch()
 	if err != nil {