Skip to content

Commit c618f3b

Browse files
Apply suggestions from code review
Co-authored-by: Alessio Perugini <[email protected]>
1 parent dfc606e commit c618f3b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Diff for: internal/builder/diagnostics/compiler_detection.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ var runProcess = func(args ...string) []string {
4444
}
4545

4646
// DetectCompilerFromCommandLine tries to detect a compiler from a given command line.
47-
// If probleCompiler is true, the compiler may be executed with different flags to
47+
// If probeCompiler is true, the compiler may be executed with different flags to
4848
// infer the version or capabilities.
4949
func DetectCompilerFromCommandLine(args []string, probeCompiler bool) *DetectedCompiler {
5050
if len(args) == 0 {
@@ -61,7 +61,7 @@ func DetectCompilerFromCommandLine(args []string, probeCompiler bool) *DetectedC
6161
}
6262

6363
if family == "gcc" && probeCompiler {
64-
// Run "gcc --verion" to obtain more info
64+
// Run "gcc --version" to obtain more info
6565
res.DetailedVersion = runProcess(args[0], "--version")
6666

6767
// Usually on the first line we get the compiler architecture and

Diff for: internal/builder/diagnostics/parser_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,5 @@ func runParserTest(t *testing.T, testFile string) {
5252
require.NoError(t, err)
5353
golden, err := paths.New("testdata", "compiler_outputs", testFile+".json").ReadFile()
5454
require.NoError(t, err)
55-
// fmt.Println(string(output))
5655
require.Equal(t, string(golden), string(output))
5756
}

0 commit comments

Comments
 (0)