Added check for missing library version/name in args

Author: cmaglie

cli/globals/args.go

@@ -94,8 +94,14 @@ func ParseLibraryReferenceArg(arg string) (*LibraryReferenceArg, error) {
 	ret := &LibraryReferenceArg{}
 	// TODO: check library Name constraints
 	// TODO: check library Version constraints
+	if tokens[0] == "" {
+		return nil, fmt.Errorf("invalid empty library name")
+	}
 	ret.Name = tokens[0]
 	if len(tokens) > 1 {
+		if tokens[1] == "" {
+			return nil, fmt.Errorf("invalid empty library version")
+		}
 		ret.Version = tokens[1]
 	}
 	return ret, nil

cli/globals/args_test.go

@@ -40,7 +40,6 @@ var goodLibs = []struct {
 }{
 	{"mylib", &globals.LibraryReferenceArg{"mylib", ""}},
 	{"[email protected]", &globals.LibraryReferenceArg{"mylib", "1.0"}},
-	{"mylib@", &globals.LibraryReferenceArg{"mylib", ""}},
 }
 
 var badCores = []struct {
@@ -52,6 +51,14 @@ var badCores = []struct {
 	{"arduino:avr:[email protected]", nil},
 }
 
+var badLibs = []struct {
+	in       string
+	expected *globals.LibraryReferenceArg
+}{
+	{"", nil},
+	{"mylib@", nil},
+}
+
 func TestArgsStringify(t *testing.T) {
 	for _, lib := range goodLibs {
 		require.Equal(t, lib.in, lib.expected.String())
@@ -70,19 +77,18 @@ func TestParseReferenceArgCores(t *testing.T) {
 		assert.NotNil(t, err)
 		assert.Equal(t, tt.expected, actual)
 	}
-
-	// library refs are not good as core's
-	for _, tt := range goodLibs {
-		_, err := globals.ParseReferenceArg(tt.in, true)
-		assert.NotNil(t, err)
-	}
 }
 
 func TestParseReferenceArgLibs(t *testing.T) {
 	for _, tt := range goodLibs {
 		actual, err := globals.ParseLibraryReferenceArg(tt.in)
-		assert.Nil(t, err)
-		assert.Equal(t, tt.expected, actual)
+		assert.Nil(t, err, "Testing good arg '%s'", tt.in)
+		assert.Equal(t, tt.expected, actual, "Testing good arg '%s'", tt.in)
+	}
+	for _, tt := range badLibs {
+		res, err := globals.ParseLibraryReferenceArg(tt.in)
+		require.Nil(t, res, "Testing bad arg '%s'", tt.in)
+		require.NotNil(t, err, "Testing bad arg '%s'", tt.in)
 	}
 }