Migrated TestStaticCompletions from test_completion.py to completion_test.go

Author: MatteoPologruto

internal/integrationtest/completion/completion_test.go

@@ -169,3 +169,27 @@ func TestCompletionPowershellNoDesc(t *testing.T) {
 	require.Empty(t, stdout)
 	require.Contains(t, string(stderr), "Error: command description is not supported by powershell")
 }
+
+// test if the completion suggestions returned are meaningful
+// we use the __complete hidden command
+// https://github.com/spf13/cobra/blob/master/shell_completions.md#debugging
+
+// test static completions
+func TestStaticCompletions(t *testing.T) {
+	env := testsuite.NewEnvironment(t)
+	defer env.CleanUp()
+
+	cli := integrationtest.NewArduinoCliWithinEnvironment(env, &integrationtest.ArduinoCLIConfig{
+		ArduinoCLIPath:         paths.New("..", "..", "..", "arduino-cli"),
+		UseSharedStagingFolder: true,
+	})
+
+	stdout, _, _ := cli.Run("__complete", "--format", "")
+	require.Contains(t, string(stdout), "json")
+
+	stdout, _, _ = cli.Run("__complete", "--log-format", "")
+	require.Contains(t, string(stdout), "json")
+
+	stdout, _, _ = cli.Run("__complete", "--log-level", "")
+	require.Contains(t, string(stdout), "trace")
+}

test/test_completion.py

@@ -14,38 +14,6 @@
 # a commercial license, send an email to license@arduino.cc.
 
 
-# test if the completion suggestions returned are meaningful
-# we use the __complete hidden command
-# https://github.com/spf13/cobra/blob/master/shell_completions.md#debugging
-
-# test static completions
-def test_static_completions(run_command):
-    result = run_command(
-        [
-            "__complete",
-            "--format",
-            "",
-        ]
-    )
-    assert "json" in result.stdout
-    result = run_command(
-        [
-            "__complete",
-            "--log-format",
-            "",
-        ]
-    )
-    assert "json" in result.stdout
-    result = run_command(
-        [
-            "__complete",
-            "--log-level",
-            "",
-        ]
-    )
-    assert "trace" in result.stdout
-
-
 # here we test if the completions coming from the core are working
 def test_config_completion(run_command):
     result = run_command(["__complete", "config", "add", ""])