Removed Logger.Name method (use type-assertions instead)

Author: cmaglie

Diff for: legacy/builder/i18n/errors.go

@@ -8,7 +8,7 @@ import (
 )
 
 func ErrorfWithLogger(logger Logger, format string, a ...interface{}) error {
-	if logger.Name() == "machine" {
+	if _, isMachineLogger := logger.(*MachineLogger); isMachineLogger {
 		logger.Fprintln(os.Stderr, constants.LOG_LEVEL_ERROR, format, a...)
 		return errors.New("")
 	}

Diff for: legacy/builder/i18n/i18n.go

@@ -31,7 +31,6 @@ var PLACEHOLDER = regexp.MustCompile(`{(\d)}`)
 type Logger interface {
 	Fprintln(w io.Writer, level string, format string, a ...interface{})
 	Println(level string, format string, a ...interface{})
-	Name() string
 }
 
 type LoggerToCustomStreams struct {
@@ -54,63 +53,43 @@ func (s *LoggerToCustomStreams) Println(level string, format string, a ...interf
 	s.Fprintln(nil, level, format, a...)
 }
 
-func (s *LoggerToCustomStreams) Name() string {
-	return "LoggerToCustomStreams"
-}
-
 type NoopLogger struct{}
 
-func (s NoopLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {}
+func (s *NoopLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {}
 
-func (s NoopLogger) Println(level string, format string, a ...interface{}) {}
-
-func (s NoopLogger) Name() string {
-	return "noop"
-}
+func (s *NoopLogger) Println(level string, format string, a ...interface{}) {}
 
 type HumanTagsLogger struct{}
 
-func (s HumanTagsLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {
+func (s *HumanTagsLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {
 	format = "[" + level + "] " + format
 	fprintln(w, Format(format, a...))
 }
 
-func (s HumanTagsLogger) Println(level string, format string, a ...interface{}) {
+func (s *HumanTagsLogger) Println(level string, format string, a ...interface{}) {
 	s.Fprintln(os.Stdout, level, format, a...)
 }
 
-func (s HumanTagsLogger) Name() string {
-	return "humantags"
-}
-
 type HumanLogger struct{}
 
-func (s HumanLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {
+func (s *HumanLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {
 	fprintln(w, Format(format, a...))
 }
 
-func (s HumanLogger) Println(level string, format string, a ...interface{}) {
+func (s *HumanLogger) Println(level string, format string, a ...interface{}) {
 	s.Fprintln(os.Stdout, level, format, a...)
 }
 
-func (s HumanLogger) Name() string {
-	return "human"
-}
-
 type MachineLogger struct{}
 
-func (s MachineLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {
+func (s *MachineLogger) Fprintln(w io.Writer, level string, format string, a ...interface{}) {
 	printMachineFormattedLogLine(w, level, format, a)
 }
 
-func (s MachineLogger) Println(level string, format string, a ...interface{}) {
+func (s *MachineLogger) Println(level string, format string, a ...interface{}) {
 	printMachineFormattedLogLine(os.Stdout, level, format, a)
 }
 
-func (s MachineLogger) Name() string {
-	return "machine"
-}
-
 func printMachineFormattedLogLine(w io.Writer, level string, format string, a []interface{}) {
 	a = append([]interface{}(nil), a...)
 	for idx, value := range a {

Diff for: legacy/builder/test/i18n_test.go

@@ -17,10 +17,11 @@ package test
 
 import (
 	"fmt"
+	"testing"
+
 	"github.com/arduino/arduino-cli/legacy/builder/constants"
 	"github.com/arduino/arduino-cli/legacy/builder/i18n"
 	"github.com/stretchr/testify/require"
-	"testing"
 )
 
 func TestI18NSyntax(t *testing.T) {
@@ -50,9 +51,9 @@ func TestI18NSyntax(t *testing.T) {
 
 func TestI18NInheritance(t *testing.T) {
 	var logger i18n.Logger
-	logger = i18n.HumanLogger{}
+	logger = &i18n.HumanLogger{}
 	logger.Println(constants.LOG_LEVEL_INFO, "good {0} {1}", "morning", "vietnam!")
 
-	logger = i18n.MachineLogger{}
+	logger = &i18n.MachineLogger{}
 	logger.Println(constants.LOG_LEVEL_INFO, "good {0} {1}", "morning", "vietnam!")
 }