Migrated TestInventoryCreation from test_main.py to main_test.go

Author: MatteoPologruto

Diff for: internal/integrationtest/main/main_test.go

@@ -17,6 +17,7 @@ package main_test
 
 import (
 	"encoding/json"
+	"strings"
 	"testing"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
@@ -83,3 +84,26 @@ func TestVersion(t *testing.T) {
 	// Checks if Commit's value is not empty
 	require.NotEmpty(t, jsonMap["Commit"])
 }
+
+func TestInventoryCreation(t *testing.T) {
+	// Using version as a test command
+
+	env := testsuite.NewEnvironment(t)
+	defer env.CleanUp()
+
+	cli := integrationtest.NewArduinoCliWithinEnvironment(env, &integrationtest.ArduinoCLIConfig{
+		ArduinoCLIPath:         paths.New("..", "..", "..", "arduino-cli"),
+		UseSharedStagingFolder: true,
+	})
+
+	// no logs
+	stdout, _, _ := cli.Run("version")
+	line := strings.TrimSpace(string(stdout))
+	outLines := strings.Split(line, "\n")
+	require.Len(t, outLines, 1)
+
+	// parse inventory file
+	inventoryFile := cli.DataDir().Join("inventory.yaml")
+	stream, _ := inventoryFile.ReadFile()
+	require.True(t, strings.Contains(string(stream), "installation"))
+}

Diff for: test/test_main.py

@@ -50,19 +50,3 @@ def test_log_options(run_command, data_dir):
     with open(log_file) as f:
         for line in f.readlines():
             json.loads(line)
-
-
-def test_inventory_creation(run_command, data_dir):
-    """
-    using `version` as a test command
-    """
-
-    # no logs
-    out_lines = run_command(["version"]).stdout.strip().split("\n")
-    assert len(out_lines) == 1
-
-    # parse inventory file
-    inventory_file = os.path.join(data_dir, "inventory.yaml")
-    with open(inventory_file, "r") as stream:
-        inventory = yaml.safe_load(stream)
-        assert "installation" in inventory