Add check for invalid boards.txt format

Author: per1234

Diff for: check/checkconfigurations/checkconfigurations.go

@@ -1166,6 +1166,21 @@ var configurations = []Type{
 		ErrorModes:      []checkmode.Type{checkmode.Default},
 		CheckFunction:   checkfunctions.BoardsTxtMissing,
 	},
+	{
+		ProjectType:     projecttype.Platform,
+		Category:        "configuration files",
+		Subcategory:     "boards.txt",
+		ID:              "",
+		Brief:           "Invalid boards.txt",
+		Description:     "",
+		MessageTemplate: "boards.txt has an invalid format: {{.}}",
+		DisableModes:    nil,
+		EnableModes:     []checkmode.Type{checkmode.Default},
+		InfoModes:       nil,
+		WarningModes:    nil,
+		ErrorModes:      []checkmode.Type{checkmode.Default},
+		CheckFunction:   checkfunctions.BoardsTxtFormat,
+	},
 	{
 		ProjectType:     projecttype.PackageIndex,
 		Category:        "data",

Diff for: check/checkfunctions/platform.go

@@ -37,3 +37,15 @@ func BoardsTxtMissing() (result checkresult.Type, output string) {
 	return checkresult.Fail, boardsTxtPath.String()
 }
 
+// BoardsTxtFormat checks for invalid boards.txt format.
+func BoardsTxtFormat() (result checkresult.Type, output string) {
+	if !checkdata.ProjectPath().Join("boards.txt").Exist() {
+		return checkresult.NotRun, "boards.txt missing"
+	}
+
+	if checkdata.BoardsTxtLoadError() == nil {
+		return checkresult.Pass, ""
+	}
+
+	return checkresult.Fail, checkdata.BoardsTxtLoadError().Error()
+}

Diff for: check/checkfunctions/platform_test.go

@@ -71,3 +71,12 @@ func TestBoardsTxtMissing(t *testing.T) {
 	checkPlatformCheckFunction(BoardsTxtMissing, testTables, t)
 }
 
+func TestBoardsTxtFormat(t *testing.T) {
+	testTables := []platformCheckFunctionTestTable{
+		{"Missing", "missing-boards.txt", checkresult.NotRun, ""},
+		{"Valid", "valid-boards.txt", checkresult.Pass, ""},
+		{"Invalid", "invalid-boards.txt", checkresult.Fail, ""},
+	}
+
+	checkPlatformCheckFunction(BoardsTxtFormat, testTables, t)
+}

Diff for: check/checkfunctions/testdata/platforms/invalid-boards.txt/boards.txt

@@ -0,0 +1 @@
+This makes the format invalid