Skip to content

Commit ae24226

Browse files
authored
[skip-changelog] test: Fixed runners not running 'board' integration test (#2381)
* test: Fixed runners not running 'board' integration test * Fixed integration test * Fixed integration test failure: <<< Run completed (err = <nil>) environment.go:52: Error Trace: D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:52 D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:63 D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:63 D:/a/arduino-cli/arduino-cli/internal/integrationtest/environment.go:69 D:/a/arduino-cli/arduino-cli/internal/integrationtest/board/board_test.go:638 Error: Received unexpected error: remove C:\Users\runneradmin\AppData\Local\Temp\cli2634248494\A\inventory.yaml: The process cannot access the file because it is being used by another process. Test: TestCLIStartupWithCorruptedInventory --- FAIL: TestCLIStartupWithCorruptedInventory (8.45s)
1 parent b0e28d9 commit ae24226

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

Diff for: .github/workflows/test-go-task.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,9 @@ jobs:
7070

7171
- name: Collect tests
7272
id: collection
73+
# jq flags must be "-cRn" see: https://stackoverflow.com/a/68859958/1655275
7374
run: |
74-
echo "tests-data=$(go list ./internal/integrationtest/... | grep integrationtest/ | tr "/" " " | cut -d " " -f 6 | jq -cR '[inputs]')" >> $GITHUB_OUTPUT
75+
echo "tests-data=$(go list ./internal/integrationtest/... | grep integrationtest/ | tr "/" " " | cut -d " " -f 6 | jq -cRn '[inputs]')" >> $GITHUB_OUTPUT
7576
7677
test-integration:
7778
needs: tests-collector

Diff for: internal/integrationtest/board/board_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -630,6 +630,7 @@ func TestCLIStartupWithCorruptedInventory(t *testing.T) {
630630
require.NoError(t, err)
631631
_, err = f.WriteString(`data: '[{"name":"WCH;32?'","fqbn":"esp32:esp32:esp32s3camlcd"}]'`)
632632
require.NoError(t, err)
633+
require.NoError(t, f.Close())
633634

634635
// the CLI should not be able to load inventory and report it to the logs
635636
_, stderr, err := cli.Run("core", "update-index", "-v")

Diff for: internal/integrationtest/board/hardware_loading_test.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,7 @@ func TestHardwareLoading(t *testing.T) {
154154
out, _, err := cli.Run("core", "list", "--format", "json")
155155
require.NoError(t, err)
156156
jsonOut := requirejson.Parse(t, out)
157-
if runtime.GOOS == "windows" {
158-
// a package is a symlink, and windows does not support them
159-
jsonOut.LengthMustEqualTo(2)
160-
} else {
161-
jsonOut.LengthMustEqualTo(3)
162-
}
157+
jsonOut.LengthMustEqualTo(3)
163158
jsonOut.MustContain(`[
164159
{
165160
"id": "arduino:avr",

0 commit comments

Comments
 (0)