use t.Setenv instead of os.Setenv in tests

Author: alessio-perugini

arduino/cores/packagemanager/package_manager_test.go

@@ -431,7 +431,7 @@ func TestBoardOrdering(t *testing.T) {
 }
 
 func TestFindToolsRequiredForBoard(t *testing.T) {
-	os.Setenv("ARDUINO_DATA_DIR", dataDir1.String())
+	t.Setenv("ARDUINO_DATA_DIR", dataDir1.String())
 	configuration.Settings = configuration.Init("")
 	pmb := NewBuilder(
 		dataDir1,

commands/board/list_test.go

@@ -19,7 +19,6 @@ import (
 	"fmt"
 	"net/http"
 	"net/http/httptest"
-	"os"
 	"testing"
 
 	"github.com/arduino/arduino-cli/arduino/cores/packagemanager"
@@ -110,7 +109,7 @@ func TestBoardDetectionViaAPIWithNonUSBPort(t *testing.T) {
 
 func TestBoardIdentifySorting(t *testing.T) {
 	dataDir := paths.TempDir().Join("test", "data_dir")
-	os.Setenv("ARDUINO_DATA_DIR", dataDir.String())
+	t.Setenv("ARDUINO_DATA_DIR", dataDir.String())
 	dataDir.MkdirAll()
 	defer paths.TempDir().Join("test").RemoveAll()
 

commands/core/search_test.go

@@ -16,7 +16,6 @@
 package core
 
 import (
-	"os"
 	"testing"
 
 	"github.com/arduino/arduino-cli/configuration"
@@ -30,8 +29,8 @@ func TestPlatformSearch(t *testing.T) {
 
 	dataDir := paths.TempDir().Join("test", "data_dir")
 	downloadDir := paths.TempDir().Join("test", "staging")
-	os.Setenv("ARDUINO_DATA_DIR", dataDir.String())
-	os.Setenv("ARDUINO_DOWNLOADS_DIR", downloadDir.String())
+	t.Setenv("ARDUINO_DATA_DIR", dataDir.String())
+	t.Setenv("ARDUINO_DOWNLOADS_DIR", downloadDir.String())
 	dataDir.MkdirAll()
 	downloadDir.MkdirAll()
 	defer paths.TempDir().Join("test").RemoveAll()
@@ -323,8 +322,8 @@ func TestPlatformSearch(t *testing.T) {
 func TestPlatformSearchSorting(t *testing.T) {
 	dataDir := paths.TempDir().Join("test", "data_dir")
 	downloadDir := paths.TempDir().Join("test", "staging")
-	os.Setenv("ARDUINO_DATA_DIR", dataDir.String())
-	os.Setenv("ARDUINO_DOWNLOADS_DIR", downloadDir.String())
+	t.Setenv("ARDUINO_DATA_DIR", dataDir.String())
+	t.Setenv("ARDUINO_DOWNLOADS_DIR", downloadDir.String())
 	dataDir.MkdirAll()
 	downloadDir.MkdirAll()
 	defer paths.TempDir().Join("test").RemoveAll()

internal/integrationtest/compile_3/core_caching_test.go

@@ -16,9 +16,9 @@
 package compile_test
 
 import (
+	"slices"
 	"strings"
 	"testing"
-	"slices"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
 	"github.com/arduino/go-paths-helper"