Skip to content

Commit 95729fc

Browse files
cmaglieper1234
andauthored
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent b0375f0 commit 95729fc

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Diff for: cli/arguments/port.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func (p *Port) AddToCommand(cmd *cobra.Command) {
5757

5858
// GetPortAddressAndProtocol returns only the port address and the port protocol
5959
// without any other port metadata obtained from the discoveries.
60-
// This method allows will bypass the discoveries if:
60+
// This method will bypass the discoveries if:
6161
// - a nil instance is passed: in this case the plain port and protocol arguments are returned (even if empty)
6262
// - a protocol is specified: in this case the discoveries are not needed to autodetect the protocol.
6363
func (p *Port) GetPortAddressAndProtocol(instance *rpc.Instance, sk *sketch.Sketch) (string, string, error) {

Diff for: cli/board/attach.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import (
2828
func initAttachCommand() *cobra.Command {
2929
var port arguments.Port
3030
attachCommand := &cobra.Command{
31-
Use: fmt.Sprintf("attach [-p <%s>] [-b <%s>] [%s]", tr("port"), tr("FQBN"), tr("sketchPath")),
31+
Use: fmt.Sprintf("attach [-p <%s> [-l <%s>]] [-b <%s>] [%s]", tr("port"), tr("protocol"), tr("FQBN"), tr("sketchPath")),
3232
Short: tr("Attaches a sketch to a board."),
3333
Long: tr("Attaches a sketch to a board."),
3434
Example: " " + os.Args[0] + " board attach -p /dev/ttyACM0\n" +

Diff for: docs/UPGRADING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ The errors are automatically sent to output via `feedback` package, as for the o
5656

5757
### `board attach` CLI command changed behaviour
5858

59-
The `board attach` CLI command has changed behaviour: now it just pick whatever port and FQBN is passed as parameter and
60-
saves it in the `sketch.json` file, without any validity check or board autodetection.
59+
The `board attach` CLI command has changed behaviour: now it just picks whatever port and FQBN is passed as parameter
60+
and saves it in the `sketch.json` file, without any validity check or board autodetection.
6161

6262
### `cc.arduino.cli.commands.v1.BoardAttach` gRPC interface command removal
6363

64-
The `cc.arduino.cli.commands.v1.BoardAttach` gRPC command have been removed. This feature is no more available throguh
64+
The `cc.arduino.cli.commands.v1.BoardAttach` gRPC command has been removed. This feature is no longer available through
6565
gRPC.
6666

6767
## 0.28.0

0 commit comments

Comments
 (0)