refactor: renamed mode

Author: Luca Bianconi

internal/cli/compile/compile.go

@@ -50,11 +50,12 @@ type showPropertiesMode enumflag.Flag
 const (
 	showPropertiesModeDisabled showPropertiesMode = iota // default when missing flag
 	showPropertiesModePattern
-	showPropertiesModeExpanded
+	showPropertiesModeValue
 )
 
 var showPropertiesModeIds = map[showPropertiesMode][]string{
-	showPropertiesModeExpanded: {"expanded"},
+	showPropertiesModeDisabled: {"disabled"},
+	showPropertiesModeValue:    {"value"},
 	showPropertiesModePattern:  {"pattern"},
 }
 
@@ -111,9 +112,9 @@ func NewCommand() *cobra.Command {
 	profileArg.AddToCommand(compileCommand)
 	compileCommand.Flags().BoolVar(&dumpProfile, "dump-profile", false, tr("Create and print a profile configuration from the build."))
 	compileCommand.Flags().Var(
-		enumflag.New(&showProperties, "show-properties", showPropertiesModeIds, enumflag.EnumCaseInsensitive),
+		enumflag.New(&showProperties, "string", showPropertiesModeIds, enumflag.EnumCaseInsensitive),
 		"show-properties",
-		tr("Show all build properties used instead of compiling."),
+		tr(`Show build properties instead of compiling. With "pattern" properties are returned as they are defined. If "value" the placeholders are replaced with compilation context values.`),
 	)
 	compileCommand.Flags().Lookup("show-properties").NoOptDefVal = "pattern" // default if the flag is present with no value
 	compileCommand.Flags().BoolVar(&preprocess, "preprocess", false, tr("Print preprocessed code to stdout instead of compiling."))
@@ -373,7 +374,7 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
 		}
 		feedback.FatalResult(res, feedback.ErrGeneric)
 	}
-	if showProperties == showPropertiesModeExpanded {
+	if showProperties == showPropertiesModeValue {
 		expandPropertiesInResult(res)
 	}
 	feedback.PrintResult(res)

internal/integrationtest/compile_3/compile_show_properties_test.go

@@ -95,19 +95,19 @@ func TestCompileShowProperties(t *testing.T) {
 	require.True(t, props.ContainsKey("archive_file_path"))
 	require.Contains(t, props.Get("archive_file_path"), "{build.path}")
 
-	// Test --show-properties=expanded output is clean
+	// Test --show-properties=value output is clean
 	// properties are expanded
-	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=expanded", bareMinimum.String())
+	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=value", bareMinimum.String())
 	require.NoError(t, err)
 	props, err = properties.LoadFromBytes(stdout)
 	require.NoError(t, err, "Output must be a clean property list")
 	require.Empty(t, stderr)
 	require.True(t, props.ContainsKey("archive_file_path"))
 	require.NotContains(t, props.Get("archive_file_path"), "{build.path}")
 
-	// Test --show-properties=expanded --format JSON output is clean
+	// Test --show-properties=value --format JSON output is clean
 	// properties are expanded
-	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=expanded", "--format", "json", bareMinimum.String())
+	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=value", "--format", "json", bareMinimum.String())
 	require.NoError(t, err)
 	require.Empty(t, stderr)
 	props, err = properties.LoadFromSlice(