Better git url handling

Author: silvanocerza

Diff for: arduino/libraries/librariesmanager/install.go

@@ -137,7 +137,7 @@ func (lm *LibrariesManager) InstallGitLib(gitURL string) error {
 
 func parseGitURL(gitURL string) (string, error) {
 	var res string
-	if strings.HasPrefix(gitURL, "git") || strings.HasPrefix(gitURL, "ssh") {
+	if strings.HasPrefix(gitURL, "git@") {
 		// We can't parse these as URLs
 		i := strings.LastIndex(gitURL, "/")
 		res = strings.TrimRight(gitURL[i+1:], ".git")

Diff for: test/test_lib.py

@@ -215,7 +215,7 @@ def test_install_git_url_and_zip_path_flags_visibility(run_command, data_dir, do
     assert "--git-url and --zip-path flags allow installing untrusted files, use it at your own risk." in res.stdout
 
 
-def test_install_with_git_url(run_command, data_dir, downloads_dir):
+def test_install_with_git_url_https(run_command, data_dir, downloads_dir):
     # Initialize configs to enable --git-url flag
     env = {
         "ARDUINO_DATA_DIR": data_dir,
@@ -236,6 +236,27 @@ def test_install_with_git_url(run_command, data_dir, downloads_dir):
     assert "Error installing Git Library: repository already exists" in res.stderr
 
 
+def test_install_with_git_url_ssh(run_command, data_dir, downloads_dir):
+    # Initialize configs to enable --git-url flag
+    env = {
+        "ARDUINO_DATA_DIR": data_dir,
+        "ARDUINO_DOWNLOADS_DIR": downloads_dir,
+        "ARDUINO_SKETCHBOOK_DIR": data_dir,
+        "ARDUINO_ENABLE_UNSAFE_LIBRARY_INSTALL": "true",
+    }
+    assert run_command("config init --dest-dir .", custom_env=env)
+
+    # Test git-url library install
+    res = run_command("lib install --git-url [email protected]:arduino-libraries/WiFi101.git")
+    assert res.ok
+    assert "--git-url and --zip-path flags allow installing untrusted files, use it at your own risk." in res.stdout
+
+    # Test failing-install as repository already exists
+    res = run_command("lib install --git-url [email protected]:arduino-libraries/WiFi101.git")
+    assert "--git-url and --zip-path flags allow installing untrusted files, use it at your own risk." in res.stdout
+    assert "Error installing Git Library: repository already exists" in res.stderr
+
+
 def test_install_with_zip_path(run_command, data_dir, downloads_dir):
     # Initialize configs to enable --zip-path flag
     env = {