Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 874e94b

Browse files
committedMar 13, 2024
Moved a batch of function from commands/* subpackage to commands
This commit is preparatory to move all the implementation of ArduinoCoreService interface directly as methods of ArduinoCoreService. The goal is to turn ArduinoCoreService into a proper implementation instead of being a mere proxy to global functions.
1 parent 752709a commit 874e94b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+144
-162
lines changed
 

‎.github/workflows/check-go-task.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ jobs:
237237
module:
238238
- path: internal/arduino/discovery/discovery_client
239239
- path: rpc/internal/client_example
240-
- path: commands/daemon/term_example
240+
- path: commands/term_example
241241

242242
steps:
243243
- name: Checkout repository

‎commands/instances.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ import (
4343
"google.golang.org/grpc/status"
4444
)
4545

46-
var tr = i18n.Tr
47-
4846
func installTool(pm *packagemanager.PackageManager, tool *cores.ToolRelease, downloadCB rpc.DownloadProgressCB, taskCB rpc.TaskProgressCB) error {
4947
pme, release := pm.NewExplorer()
5048
defer release()

0 commit comments

Comments
 (0)