Migrate TestCompileManuallyInstalledPlatform from test_compile_part_3.py to compile_part_3_test.go

Author: MatteoPologruto

Diff for: internal/integrationtest/compile/compile_part_3_test.go

@@ -22,6 +22,8 @@ import (
 	"github.com/arduino/arduino-cli/internal/integrationtest"
 	"github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
+	"gopkg.in/src-d/go-git.v4"
+	"gopkg.in/src-d/go-git.v4/plumbing"
 )
 
 func TestCompileSketchWithPdeExtesnion(t *testing.T) {
@@ -250,3 +252,34 @@ func TestCompileUsingBoardsLocalTxt(t *testing.T) {
 	_, _, err = cli.Run("compile", "--clean", "-b", fqbn, sketchPath.String())
 	require.NoError(t, err)
 }
+
+func TestCompileManuallyInstalledPlatform(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	sketchName := "CompileSketchManuallyInstalledPlatformUsingPlatformLocalTxt"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino-beta-development:avr:uno"
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	// Manually installs a core in sketchbooks hardware folder
+	gitUrl := "https://github.com/arduino/ArduinoCore-avr.git"
+	repoDir := cli.SketchbookDir().Join("hardware", "arduino-beta-development", "avr")
+	_, err = git.PlainClone(repoDir.String(), false, &git.CloneOptions{
+		URL:           gitUrl,
+		ReferenceName: plumbing.NewTagReferenceName("1.8.3"),
+	})
+	require.NoError(t, err)
+
+	// Installs also the same core via CLI so all the necessary tools are installed
+	_, _, err = cli.Run("core", "install", "arduino:[email protected]")
+	require.NoError(t, err)
+
+	// Verifies compilation works without issues
+	_, _, err = cli.Run("compile", "--clean", "-b", fqbn, sketchPath.String())
+	require.NoError(t, err)
+}

Diff for: test/test_compile_part_3.py

@@ -39,26 +39,6 @@
 #    assert "Skipping dependencies detection for precompiled library Arduino_TensorFlowLite" in result.stdout
 
 
-def test_compile_manually_installed_platform(run_command, data_dir):
-    assert run_command(["update"])
-
-    sketch_name = "CompileSketchManuallyInstalledPlatformUsingPlatformLocalTxt"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino-beta-development:avr:uno"
-    assert run_command(["sketch", "new", sketch_path])
-
-    # Manually installs a core in sketchbooks hardware folder
-    git_url = "https://github.com/arduino/ArduinoCore-avr.git"
-    repo_dir = Path(data_dir, "hardware", "arduino-beta-development", "avr")
-    assert Repo.clone_from(git_url, repo_dir, multi_options=["-b 1.8.3"])
-
-    # Installs also the same core via CLI so all the necessary tools are installed
-    assert run_command(["core", "install", "arduino:[email protected]"])
-
-    # Verifies compilation works without issues
-    assert run_command(["compile", "--clean", "-b", fqbn, sketch_path])
-
-
 def test_compile_manually_installed_platform_using_platform_local_txt(run_command, data_dir):
     assert run_command(["update"])