legacy: removed i18n on unneded message

Author: cmaglie

legacy/builder/builder_utils/utils.go

@@ -512,7 +512,7 @@ func PrepareCommandForRecipe(ctx *types.Context, buildProperties *properties.Map
 		commandLine = properties.DeleteUnexpandedPropsFromString(commandLine)
 	}
 
-	command, err := utils.PrepareCommand(commandLine, logger)
+	command, err := utils.PrepareCommand(commandLine)
 
 	// if the overall commandline is too long for the platform
 	// try reducing the length by making the filenames relative

legacy/builder/constants/constants.go

@@ -90,7 +90,6 @@ const MSG_BUILD_OPTIONS_CHANGED = "Build options changed, rebuilding all"
 const MSG_CANT_FIND_SKETCH_IN_PATH = "Unable to find {0} in {1}"
 const MSG_FQBN_INVALID = "{0} is not a valid fully qualified board name. Required format is targetPackageName:targetPlatformName:targetBoardName."
 const MSG_FIND_INCLUDES_FAILED = "Error while detecting libraries included by {0}"
-const MSG_INVALID_QUOTING = "Invalid quoting: no closing [{0}] char found."
 const MSG_LIB_LEGACY = "(legacy)"
 const MSG_LIBRARIES_MULTIPLE_LIBS_FOUND_FOR = "Multiple libraries were found for \"{0}\""
 const MSG_LIBRARIES_NOT_USED = " Not used: {0}"

legacy/builder/ctags_runner.go

@@ -41,7 +41,7 @@ func (s *CTagsRunner) Run(ctx *types.Context) error {
 	}
 
 	commandLine := properties.ExpandPropsInString(pattern)
-	command, err := utils.PrepareCommand(commandLine, logger)
+	command, err := utils.PrepareCommand(commandLine)
 	if err != nil {
 		return errors.WithStack(err)
 	}

legacy/builder/preprocess_sketch.go

@@ -106,7 +106,7 @@ func (s *ArduinoPreprocessorRunner) Run(ctx *types.Context) error {
 	}
 
 	commandLine := properties.ExpandPropsInString(pattern)
-	command, err := utils.PrepareCommand(commandLine, logger)
+	command, err := utils.PrepareCommand(commandLine)
 	if err != nil {
 		return errors.WithStack(err)
 	}

legacy/builder/test/utils_test.go

@@ -16,17 +16,17 @@
 package test
 
 import (
-	"github.com/arduino/arduino-cli/legacy/builder/i18n"
-	"github.com/arduino/arduino-cli/legacy/builder/utils"
-	"github.com/stretchr/testify/require"
 	"strings"
 	"testing"
+
+	"github.com/arduino/arduino-cli/legacy/builder/utils"
+	"github.com/stretchr/testify/require"
 )
 
 func TestCommandLineParser(t *testing.T) {
 	command := "\"/home/federico/materiale/works_Arduino/Arduino/build/hardware/tools/coan\" source -m -E -P -kb -c -g -Os -w -ffunction-sections -fdata-sections -MMD -mmcu=atmega32u4 -DF_CPU=16000000L -DARDUINO=010600 -DARDUINO_AVR_LEONARDO -DARDUINO_ARCH_AVR  -DUSB_VID=0x2341 -DUSB_PID=0x8036 '-DUSB_MANUFACTURER=' '-DUSB_PRODUCT=\"Arduino Leonardo\"' \"/tmp/sketch321469072.cpp\""
 
-	parts, err := utils.ParseCommandLine(command, i18n.HumanLogger{})
+	parts, err := utils.ParseCommandLine(command)
 	NoError(t, err)
 
 	require.Equal(t, 23, len(parts))
@@ -78,7 +78,7 @@ func TestPrintableCommand(t *testing.T) {
 func TestCommandLineParserError(t *testing.T) {
 	command := "\"command missing quote"
 
-	_, err := utils.ParseCommandLine(command, i18n.HumanLogger{})
+	_, err := utils.ParseCommandLine(command)
 	require.Error(t, err)
 }
 

legacy/builder/utils/utils.go

@@ -31,15 +31,14 @@ import (
 
 	"github.com/arduino/arduino-cli/legacy/builder/constants"
 	"github.com/arduino/arduino-cli/legacy/builder/gohasissues"
-	"github.com/arduino/arduino-cli/legacy/builder/i18n"
 	"github.com/arduino/arduino-cli/legacy/builder/types"
 	paths "github.com/arduino/go-paths-helper"
 	"github.com/pkg/errors"
 	"golang.org/x/text/transform"
 	"golang.org/x/text/unicode/norm"
 )
 
-func ParseCommandLine(input string, logger i18n.Logger) ([]string, error) {
+func ParseCommandLine(input string) ([]string, error) {
 	var parts []string
 	escapingChar := constants.EMPTY_STRING
 	escapedArg := constants.EMPTY_STRING
@@ -74,7 +73,7 @@ func ParseCommandLine(input string, logger i18n.Logger) ([]string, error) {
 	}
 
 	if escapingChar != constants.EMPTY_STRING {
-		return nil, i18n.ErrorfWithLogger(logger, constants.MSG_INVALID_QUOTING, escapingChar)
+		return nil, errors.Errorf("Invalid quoting: no closing [%s] char found.", escapingChar)
 	}
 
 	return parts, nil
@@ -189,8 +188,8 @@ func TrimSpace(value string) string {
 	return strings.TrimSpace(value)
 }
 
-func PrepareCommand(pattern string, logger i18n.Logger) (*exec.Cmd, error) {
-	parts, err := ParseCommandLine(pattern, logger)
+func PrepareCommand(pattern string) (*exec.Cmd, error) {
+	parts, err := ParseCommandLine(pattern)
 	if err != nil {
 		return nil, errors.WithStack(err)
 	}