use generic impl of uniquify

Author: alessio-perugini

internal/cli/config/add.go

@@ -25,33 +25,10 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// // TODO: When update to go 1.18 or later, convert to generic
-// //       to allow uniquify() on any slice that supports
-// //       `comparable`
-// //       See https://gosamples.dev/generics-remove-duplicates-slice/
-// func uniquify[T comparable](s []T) []T {
-// 	// use a map, which enforces unique keys
-// 	inResult := make(map[T]bool)
-// 	var result []T
-// 	// loop through input slice **in order**,
-// 	// to ensure output retains that order
-// 	// (except that it removes duplicates)
-// 	for i := 0; i < len(s); i++ {
-// 		// attempt to use the element as a key
-// 		if _, ok := inResult[s[i]]; !ok {
-// 			// if key didn't exist in map,
-// 			// add to map and append to result
-// 			inResult[s[i]] = true
-// 			result = append(result, s[i])
-// 		}
-// 	}
-// 	return result
-// }
-
-func uniquifyStringSlice(s []string) []string {
+func uniquify[T comparable](s []T) []T {
 	// use a map, which enforces unique keys
-	inResult := make(map[string]bool)
-	var result []string
+	inResult := make(map[T]bool)
+	var result []T
 	// loop through input slice **in order**,
 	// to ensure output retains that order
 	// (except that it removes duplicates)
@@ -96,7 +73,7 @@ func runAddCommand(cmd *cobra.Command, args []string) {
 
 	v := configuration.Settings.GetStringSlice(key)
 	v = append(v, args[1:]...)
-	v = uniquifyStringSlice(v)
+	v = uniquify(v)
 	configuration.Settings.Set(key, v)
 
 	if err := configuration.Settings.WriteConfig(); err != nil {

internal/cli/config/set.go

@@ -57,7 +57,7 @@ func runSetCommand(cmd *cobra.Command, args []string) {
 	var value interface{}
 	switch kind {
 	case reflect.Slice:
-		value = uniquifyStringSlice(args[1:])
+		value = uniquify(args[1:])
 	case reflect.String:
 		value = args[1]
 	case reflect.Bool: