Skip to content

Commit 7cfa718

Browse files
Remove check-python-task and the related unused dependencies
1 parent 88deccb commit 7cfa718

File tree

5 files changed

+313
-631
lines changed

5 files changed

+313
-631
lines changed

Diff for: .github/workflows/check-python-task.yml

-86
This file was deleted.

Diff for: Taskfile.yml

-17
Original file line numberDiff line numberDiff line change
@@ -235,22 +235,6 @@ tasks:
235235
cmds:
236236
- clang-format -i rpc/cc/arduino/cli/*/*/*.proto
237237

238-
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-python-task/Taskfile.yml
239-
python:format:
240-
desc: Format Python files
241-
deps:
242-
- task: poetry:install-deps
243-
cmds:
244-
- poetry run black .
245-
246-
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-python-task/Taskfile.yml
247-
python:lint:
248-
desc: Lint Python code
249-
deps:
250-
- task: poetry:install-deps
251-
cmds:
252-
- poetry run flake8 --show-source
253-
254238
build:
255239
desc: Build the project
256240
deps:
@@ -288,7 +272,6 @@ tasks:
288272
cmds:
289273
- task: go:vet
290274
- task: go:lint
291-
- task: python:lint
292275
- task: protoc:check
293276

294277
check-legacy:

Diff for: docs/CONTRIBUTING.md

-17
Original file line numberDiff line numberDiff line change
@@ -187,23 +187,6 @@ To run very specific test functions:
187187
go test -v github.com/arduino/arduino-cli/internal/integrationtest/lib -run TestLibUpgradeCommand
188188
```
189189

190-
#### Linting and formatting
191-
192-
When editing any Python file in the project remember to run linting checks with:
193-
194-
```shell
195-
task python:lint
196-
```
197-
198-
This will run `flake8` automatically and return any error in the code formatting, if not already installed it will also
199-
install integration tests dependencies.
200-
201-
In case of linting errors you should be able to solve most of them by automatically formatting with:
202-
203-
```shell
204-
task python:format
205-
```
206-
207190
### Dependency license metadata
208191

209192
Metadata about the license types of all dependencies is cached in the repository. To update this cache, run the

0 commit comments

Comments
 (0)