Skip to content

Commit 7a3f27a

Browse files
committed
Changing return type of disconnect from bool to void since the operation can't fail anyway
1 parent f675a81 commit 7a3f27a

5 files changed

+5
-7
lines changed

Diff for: src/ArduinoIoTCloud.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class ArduinoIoTCloudClass
133133
protected:
134134

135135
virtual int connect () = 0;
136-
virtual bool disconnect() = 0;
136+
virtual void disconnect() = 0;
137137

138138
inline ArduinoIoTConnectionStatus getIoTStatus() { return _iot_status; }
139139

Diff for: src/ArduinoIoTCloudLPWAN.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,9 @@ int ArduinoIoTCloudLPWAN::connect()
114114
return 1;
115115
}
116116

117-
bool ArduinoIoTCloudLPWAN::disconnect()
117+
void ArduinoIoTCloudLPWAN::disconnect()
118118
{
119119
_connection->disconnect();
120-
return true;
121120
}
122121

123122
/******************************************************************************

Diff for: src/ArduinoIoTCloudLPWAN.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ArduinoIoTCloudLPWAN : public ArduinoIoTCloudClass
5353
protected:
5454

5555
virtual int connect () override;
56-
virtual bool disconnect () override;
56+
virtual void disconnect () override;
5757

5858

5959
private:

Diff for: src/ArduinoIoTCloudTCP.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,9 @@ int ArduinoIoTCloudTCP::connect()
227227
return CONNECT_SUCCESS;
228228
}
229229

230-
bool ArduinoIoTCloudTCP::disconnect()
230+
void ArduinoIoTCloudTCP::disconnect()
231231
{
232232
_mqttClient->stop();
233-
return true;
234233
}
235234

236235
/******************************************************************************

Diff for: src/ArduinoIoTCloudTCP.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass
8282
protected:
8383

8484
virtual int connect () override;
85-
virtual bool disconnect () override;
85+
virtual void disconnect () override;
8686

8787

8888
private:

0 commit comments

Comments
 (0)