Migrate TestCompileWithBuildPropertyContainingQuotes from

test_compile_part_1.py to compile_part_1_test.go

Author: MatteoPologruto

Diff for: internal/integrationtest/compile/compile_part_1_test.go

@@ -380,3 +380,38 @@ func TestCompileWithBuildPropertiesFlag(t *testing.T) {
 	require.Contains(t, string(stdout), "-DFIRST_PIN=1")
 	require.Contains(t, string(stdout), "-DSECOND_PIN=2")
 }
+
+func TestCompileWithBuildPropertyContainingQuotes(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Install Arduino AVR Boards
+	_, _, err = cli.Run("core", "install", "arduino:[email protected]")
+	require.NoError(t, err)
+
+	// Copy sketch
+	sketchName := "sketch_with_single_string_define"
+	p, err := paths.Getwd()
+	require.NoError(t, err)
+	require.NotNil(t, p)
+	testSketch := p.Parent().Join("testdata", sketchName)
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	err = testSketch.CopyDirTo(sketchPath)
+	require.NoError(t, err)
+
+	fqbn := "arduino:avr:uno"
+
+	// Compile using a build property with quotes
+	stdout, _, err := cli.Run("compile",
+		"-b",
+		fqbn,
+		`--build-property=build.extra_flags="-DMY_DEFINE="hello world""`,
+		sketchPath.String(),
+		"--verbose")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), `-DMY_DEFINE=\"hello world\"`)
+}

Diff for: test/test_compile_part_1.py

@@ -25,31 +25,6 @@
 from .common import running_on_ci
 
 
-def test_compile_with_build_property_containing_quotes(run_command, data_dir, copy_sketch):
-    # Init the environment explicitly
-    assert run_command(["core", "update-index"])
-
-    # Install Arduino AVR Boards
-    assert run_command(["core", "install", "arduino:[email protected]"])
-
-    sketch_path = copy_sketch("sketch_with_single_string_define")
-    fqbn = "arduino:avr:uno"
-
-    # Compile using a build property with quotes
-    res = run_command(
-        [
-            "compile",
-            "-b",
-            fqbn,
-            '--build-property=build.extra_flags=\\"-DMY_DEFINE=\\"hello world\\"\\"',
-            sketch_path,
-            "--verbose",
-        ]
-    )
-    assert res.ok
-    assert '-DMY_DEFINE=\\"hello world\\"' in res.stdout
-
-
 def test_compile_with_multiple_build_property_flags(run_command, data_dir, copy_sketch, working_dir):
     # Init the environment explicitly
     assert run_command(["core", "update-index"])