Skip to content

Commit 74cdc80

Browse files
authored
Introduce new "v" version format (#2374)
we'll keep 0.35.x release branch name. We'll use "v" only for the tag, this way the documentation branches will work just like before, we are using "v" only for the github tag this way we are semver compliant
1 parent 4b2a32b commit 74cdc80

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

Diff for: .github/workflows/release-go-task.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ env:
1313
on:
1414
push:
1515
tags:
16-
- "[0-9]+.[0-9]+.[0-9]+*"
16+
- "v[0-9]+.[0-9]+.[0-9]+*"
1717

1818
jobs:
1919
create-release-artifacts:
@@ -45,7 +45,7 @@ jobs:
4545
if: matrix.os == 'Windows_32bit'
4646
uses: arduino/create-changelog@v1
4747
with:
48-
tag-regex: '^[0-9]+\.[0-9]+\.[0-9]+.*$'
48+
tag-regex: '^v[0-9]+\.[0-9]+\.[0-9]+.*$'
4949
filter-regex: '^\[(skip|changelog)[ ,-](skip|changelog)\].*'
5050
case-insensitive-regex: true
5151
changelog-file-path: "${{ env.DIST_DIR }}/CHANGELOG.md"

Diff for: Taskfile.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ vars:
363363
TIMESTAMP_SHORT:
364364
sh: echo "{{now | date "20060102"}}"
365365
TAG:
366-
sh: echo "$(git tag --points-at=HEAD 2> /dev/null | head -n1)"
366+
sh: echo "$(git tag --points-at=HEAD 2> /dev/null | head -n1 | sed 's/^v//')"
367367
VERSION: "{{if .NIGHTLY}}nightly-{{.TIMESTAMP_SHORT}}{{else if .TAG}}{{.TAG}}{{else}}{{.PACKAGE_NAME_PREFIX}}git-snapshot{{end}}"
368368
CONFIGURATION_PACKAGE: "github.com/arduino/arduino-cli/version"
369369
LDFLAGS: >-

Diff for: docs/UPGRADING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Here you can find a list of migration guides to handle breaking changes between releases of the CLI.
44

5-
## 0.35.0
5+
## v0.35.0
66

77
### CLI `debug --info` changed JSON output.
88

Diff for: install.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ initDownloadTool() {
8484
checkLatestVersion() {
8585
# Use the GitHub releases webpage to find the latest version for this project
8686
# so we don't get rate-limited.
87-
CHECKLATESTVERSION_REGEX="[0-9][A-Za-z0-9\.-]*"
87+
CHECKLATESTVERSION_REGEX="v?[0-9][A-Za-z0-9\.-]*"
8888
CHECKLATESTVERSION_LATEST_URL="https://github.com/${PROJECT_OWNER}/${PROJECT_NAME}/releases/latest"
8989
if [ "$DOWNLOAD_TOOL" = "curl" ]; then
9090
CHECKLATESTVERSION_TAG=$(curl -SsL $CHECKLATESTVERSION_LATEST_URL | grep -o "<title>Release $CHECKLATESTVERSION_REGEX · ${PROJECT_OWNER}/${PROJECT_NAME}" | grep -o "$CHECKLATESTVERSION_REGEX")

0 commit comments

Comments
 (0)