Skip to content

Commit 742d638

Browse files
committed
use an ancient protoc version to expand globs
document the reason
1 parent 63f5447 commit 742d638

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Diff for: appveyor.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ environment:
1212
PROTOC_PATH: c:\protoc
1313
PROTOC_BINARY: protoc.exe
1414
# add protoc, gopath and override default Python 2.7
15-
PATH: $(PROTOC_PATH)\bin;$(GOPATH)\bin;C:\Python37;C:\Python37\Scripts;$(PATH)
15+
PATH: $(PROTOC_PATH);$(PROTOC_PATH)\bin;$(GOPATH)\bin;C:\Python37;C:\Python37\Scripts;$(PATH)
1616

1717
stack: go 1.12
1818

@@ -26,9 +26,10 @@ install:
2626
# Python dependencies needed at test time
2727
- python -V
2828
- pip install -r test\requirements.txt
29-
# protobuf tooling needed at test time
29+
# protobuf tooling needed at test time. We use a very old version of the compiler
30+
# because of this: https://github.com/protocolbuffers/protobuf/issues/3957
3031
- go get github.com/golang/protobuf/protoc-gen-go
31-
- curl -o protoc.zip -LO https://github.com/protocolbuffers/protobuf/releases/download/v3.8.0/protoc-3.8.0-win64.zip
32+
- curl -o protoc.zip -LO https://github.com/protocolbuffers/protobuf/releases/download/v3.4.0/protoc-3.4.0-win32.zip
3233
- 7z e protoc.zip -o%PROTOC_PATH%
3334

3435
test_script:

0 commit comments

Comments
 (0)