Skip to content

Commit 6cff889

Browse files
committed
Applied suggestion from code review
1 parent d82c3f3 commit 6cff889

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

commands/service_compile.go

+4-11
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ import (
2222
"io"
2323
"sort"
2424
"strings"
25+
"sync"
2526
"time"
2627

2728
"github.com/arduino/arduino-cli/commands/cmderrors"
2829
"github.com/arduino/arduino-cli/commands/internal/instances"
2930
"github.com/arduino/arduino-cli/internal/arduino/builder"
3031
"github.com/arduino/arduino-cli/internal/arduino/cores"
31-
"github.com/arduino/arduino-cli/internal/arduino/cores/packagemanager"
3232
"github.com/arduino/arduino-cli/internal/arduino/libraries/librariesmanager"
3333
"github.com/arduino/arduino-cli/internal/arduino/sketch"
3434
"github.com/arduino/arduino-cli/internal/arduino/utils"
@@ -78,18 +78,11 @@ func (s *arduinoCoreServerImpl) Compile(req *rpc.CompileRequest, stream rpc.Ardu
7878
exportBinaries = *e
7979
}
8080

81-
var pme *packagemanager.Explorer
82-
var release func()
83-
if _pme, _release, err := instances.GetPackageManagerExplorer(req.GetInstance()); err != nil {
81+
pme, release, err := instances.GetPackageManagerExplorer(req.GetInstance())
82+
if err != nil {
8483
return err
85-
} else {
86-
pme = _pme
87-
release = func() {
88-
_release()
89-
// Release once if called multiple times
90-
_release = func() {}
91-
}
9284
}
85+
release = sync.OnceFunc(release)
9386
defer release()
9487

9588
if pme.Dirty() {

0 commit comments

Comments
 (0)