fix: cache age check

Luca Bianconi · Luca Bianconi · commit 6ac7fce2f167 · 2023-02-03T18:31:13.000+01:00
diff --git a/buildcache/build_cache.go b/buildcache/build_cache.go
@@ -67,7 +67,7 @@ func New(baseDir *paths.Path) *BuildCache {
 }
 
 func removeIfExpired(dir *paths.Path, ttl time.Duration) {
-	fileInfo, err := dir.Join().Stat()
+	fileInfo, err := dir.Join(lastUsedFileName).Stat()
 	if err != nil {
 		return
 	}
diff --git a/buildcache/build_cache_test.go b/buildcache/build_cache_test.go
@@ -73,8 +73,6 @@ func TestPurge(t *testing.T) {
 
 	New(dirToPurge).Purge(ttl)
 
-	files, err := dirToPurge.Join("fresh").Stat()
-	require.Nil(t, err)
-	require.True(t, files.IsDir())
-	require.True(t, dirToPurge.Exist())
+	require.False(t, dirToPurge.Join("old").Exist())
+	require.True(t, dirToPurge.Join("fresh").Exist())
 }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ func New(baseDir paths.Path) BuildCache {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`func removeIfExpired(dir *paths.Path, ttl time.Duration) {`
`70`		`- fileInfo, err := dir.Join().Stat()`
	`70`	`+ fileInfo, err := dir.Join(lastUsedFileName).Stat()`
`71`	`71`	`if err != nil {`
`72`	`72`	`return`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,6 @@ func TestPurge(t *testing.T) {`
`73`	`73`
`74`	`74`	`New(dirToPurge).Purge(ttl)`
`75`	`75`
`76`		`- files, err := dirToPurge.Join("fresh").Stat()`
`77`		`- require.Nil(t, err)`
`78`		`- require.True(t, files.IsDir())`
`79`		`- require.True(t, dirToPurge.Exist())`
	`76`	`+ require.False(t, dirToPurge.Join("old").Exist())`
	`77`	`+ require.True(t, dirToPurge.Join("fresh").Exist())`
`80`	`78`	`}`