Add upgrade command to upgrade all installed cores and libs

Author: silvanocerza

cli/cli.go

@@ -39,6 +39,7 @@ import (
 	"github.com/arduino/arduino-cli/cli/output"
 	"github.com/arduino/arduino-cli/cli/sketch"
 	"github.com/arduino/arduino-cli/cli/update"
+	"github.com/arduino/arduino-cli/cli/upgrade"
 	"github.com/arduino/arduino-cli/cli/upload"
 	"github.com/arduino/arduino-cli/cli/version"
 	"github.com/arduino/arduino-cli/i18n"
@@ -90,6 +91,7 @@ func createCliCommandTree(cmd *cobra.Command) {
 	cmd.AddCommand(outdated.NewCommand())
 	cmd.AddCommand(sketch.NewCommand())
 	cmd.AddCommand(update.NewCommand())
+	cmd.AddCommand(upgrade.NewCommand())
 	cmd.AddCommand(upload.NewCommand())
 	cmd.AddCommand(debug.NewCommand())
 	cmd.AddCommand(burnbootloader.NewCommand())

cli/upgrade/upgrade.go

@@ -0,0 +1,82 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to license@arduino.cc.
+
+package upgrade
+
+import (
+	"context"
+	"os"
+
+	"github.com/arduino/arduino-cli/cli/errorcodes"
+	"github.com/arduino/arduino-cli/cli/feedback"
+	"github.com/arduino/arduino-cli/cli/instance"
+	"github.com/arduino/arduino-cli/cli/output"
+	"github.com/arduino/arduino-cli/commands/core"
+	"github.com/arduino/arduino-cli/commands/lib"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
+	"github.com/sirupsen/logrus"
+	"github.com/spf13/cobra"
+)
+
+// NewCommand creates a new `upgrade` command
+func NewCommand() *cobra.Command {
+	upgradeCommand := &cobra.Command{
+		Use:     "upgrade",
+		Short:   "Upgrades installed cores and libraries.",
+		Long:    "Upgrades installed cores and libraries to latest version.",
+		Example: "  " + os.Args[0] + " upgrade",
+		Args:    cobra.NoArgs,
+		Run:     runUpgradeCommand,
+	}
+
+	return upgradeCommand
+}
+
+func runUpgradeCommand(cmd *cobra.Command, args []string) {
+	inst, err := instance.CreateInstance()
+	if err != nil {
+		feedback.Errorf("Error upgrading: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
+	logrus.Info("Executing `arduino upgrade`")
+
+	err = lib.LibraryUpgradeAll(inst.Id, output.ProgressBar(), output.TaskProgress())
+	if err != nil {
+		feedback.Errorf("Error upgrading libraries: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
+	targets, err := core.GetPlatforms(inst.Id, true)
+	if err != nil {
+		feedback.Errorf("Error retrieving core list: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
+	for _, t := range targets {
+		r := &rpc.PlatformUpgradeReq{
+			Instance:        inst,
+			PlatformPackage: t.Platform.Package.Name,
+			Architecture:    t.Platform.Architecture,
+		}
+		_, err := core.PlatformUpgrade(context.Background(), r, output.ProgressBar(), output.TaskProgress())
+		if err != nil {
+			feedback.Errorf("Error during upgrade: %v", err)
+			os.Exit(errorcodes.ErrGeneric)
+		}
+	}
+
+	logrus.Info("Done")
+}

test/test_upgrade.py

@@ -0,0 +1,30 @@
+# This file is part of arduino-cli.
+#
+# Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+#
+# This software is released under the GNU General Public License version 3,
+# which covers the main part of arduino-cli.
+# The terms of this license can be found at:
+# https://www.gnu.org/licenses/gpl-3.0.en.html
+#
+# You can be released from the requirements of the above licenses by purchasing
+# a commercial license. Buying such a license is mandatory if you want to modify or
+# otherwise use the software for commercial activities involving the Arduino
+# software without disclosing the source code of your own applications. To purchase
+# a commercial license, send an email to license@arduino.cc.
+
+
+def test_upgrade(run_command):
+    # Updates index for cores and libraries
+    assert run_command("core update-index")
+    assert run_command("lib update-index")
+
+    # Installs an outdated core and library
+    assert run_command("core install arduino:avr@1.6.3")
+    assert run_command("lib install USBHost@1.0.0")
+
+    # Installs latest version of a core and a library
+    assert run_command("core install arduino:samd")
+    assert run_command("lib install ArduinoJson")
+
+    assert run_command("upgrade")