Skip to content

Commit 6753a12

Browse files
[BREAKING]: gRPC drop query field from LibrarySearchRequest (#2388)
1 parent b7ce9c8 commit 6753a12

File tree

4 files changed

+255
-270
lines changed

4 files changed

+255
-270
lines changed

Diff for: commands/lib/search.go

-4
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ func LibrarySearch(ctx context.Context, req *rpc.LibrarySearchRequest) (*rpc.Lib
4040
func searchLibrary(req *rpc.LibrarySearchRequest, lm *librariesmanager.LibrariesManager) *rpc.LibrarySearchResponse {
4141
res := []*rpc.SearchedLibrary{}
4242
query := req.GetSearchArgs()
43-
if query == "" {
44-
query = req.GetQuery()
45-
}
46-
4743
matcher := MatcherFromQueryString(query)
4844

4945
for _, lib := range lm.Index.Libraries {

Diff for: docs/UPGRADING.md

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ Here you can find a list of migration guides to handle breaking changes between
44

55
## 0.36.0
66

7+
### gRPC `cc.arduino.cli.commands.v1.LibrarySearchRequest` message has been changed.
8+
9+
The `query` field has been removed, use `search_args` instead.
10+
711
### CLI `core list` and `core search` changed JSON output.
812

913
Below is an example of the response containing an object with all possible keys set.

0 commit comments

Comments
 (0)