style: renamed options

Author: Luca Bianconi

Diff for: internal/cli/compile/compile.go

@@ -48,15 +48,15 @@ type showPropertiesMode int
 
 const (
 	showPropertiesModeDisabled showPropertiesMode = iota
-	showPropertiesModePattern
-	showPropertiesModeValue
+	showPropertiesModeUnexpanded
+	showPropertiesModeExpanded
 )
 
 func parseShowPropertiesMode(showProperties string) (showPropertiesMode, error) {
 	val, ok := map[string]showPropertiesMode{
-		"disabled": showPropertiesModeDisabled,
-		"pattern":  showPropertiesModePattern,
-		"value":    showPropertiesModeValue,
+		"disabled":   showPropertiesModeDisabled,
+		"unexpanded": showPropertiesModeUnexpanded,
+		"expanded":   showPropertiesModeExpanded,
 	}[showProperties]
 	if !ok {
 		return showPropertiesModeDisabled, fmt.Errorf(tr("invalid option '%s'.", showProperties))
@@ -120,9 +120,9 @@ func NewCommand() *cobra.Command {
 		&showProperties,
 		"show-properties",
 		"disabled",
-		tr(`Show build properties instead of compiling. With "pattern" properties are returned as they are defined. If "value" the placeholders are replaced with compilation context values.`),
+		tr(`Show build properties instead of compiling. With "expanded" the placeholders are replaced with compilation context values.`),
 	)
-	compileCommand.Flags().Lookup("show-properties").NoOptDefVal = "pattern" // default if the flag is present with no value
+	compileCommand.Flags().Lookup("show-properties").NoOptDefVal = "unexpanded" // default if the flag is present with no value
 	compileCommand.Flags().BoolVar(&preprocess, "preprocess", false, tr("Print preprocessed code to stdout instead of compiling."))
 	compileCommand.Flags().StringVar(&buildCachePath, "build-cache-path", "", tr("Builds of 'core.a' are saved into this path to be cached and reused."))
 	compileCommand.Flags().StringVarP(&exportDir, "output-dir", "", "", tr("Save build artifacts in this directory."))
@@ -385,7 +385,7 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
 		}
 		feedback.FatalResult(res, feedback.ErrGeneric)
 	}
-	if showPropertiesM == showPropertiesModeValue {
+	if showPropertiesM == showPropertiesModeExpanded {
 		expandPropertiesInResult(res)
 	}
 	feedback.PrintResult(res)

Diff for: internal/integrationtest/compile_3/compile_show_properties_test.go

@@ -74,19 +74,19 @@ func TestCompileShowProperties(t *testing.T) {
 	require.Empty(t, stderr)
 	requireCompileResponseJson(t, stdout)
 
-	// Test --show-properties=pattern output is clean
+	// Test --show-properties=unexpanded output is clean
 	// properties are not expanded
-	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=pattern", bareMinimum.String())
+	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=unexpanded", bareMinimum.String())
 	require.NoError(t, err)
 	props, err = properties.LoadFromBytes(stdout)
 	require.NoError(t, err, "Output must be a clean property list")
 	require.Empty(t, stderr)
 	require.True(t, props.ContainsKey("archive_file_path"))
 	require.Contains(t, props.Get("archive_file_path"), "{build.path}")
 
-	// Test --show-properties=pattern output is clean
+	// Test --show-properties=unexpanded output is clean
 	// properties are not expanded
-	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=pattern", "--format", "json", bareMinimum.String())
+	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=unexpanded", "--format", "json", bareMinimum.String())
 	require.NoError(t, err)
 	require.Empty(t, stderr)
 	props, err = properties.LoadFromSlice(
@@ -95,19 +95,19 @@ func TestCompileShowProperties(t *testing.T) {
 	require.True(t, props.ContainsKey("archive_file_path"))
 	require.Contains(t, props.Get("archive_file_path"), "{build.path}")
 
-	// Test --show-properties=value output is clean
+	// Test --show-properties=expanded output is clean
 	// properties are expanded
-	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=value", bareMinimum.String())
+	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=expanded", bareMinimum.String())
 	require.NoError(t, err)
 	props, err = properties.LoadFromBytes(stdout)
 	require.NoError(t, err, "Output must be a clean property list")
 	require.Empty(t, stderr)
 	require.True(t, props.ContainsKey("archive_file_path"))
 	require.NotContains(t, props.Get("archive_file_path"), "{build.path}")
 
-	// Test --show-properties=value --format JSON output is clean
+	// Test --show-properties=expanded --format JSON output is clean
 	// properties are expanded
-	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=value", "--format", "json", bareMinimum.String())
+	stdout, stderr, err = cli.Run("compile", "--fqbn", "arduino:avr:uno", "-v", "--show-properties=expanded", "--format", "json", bareMinimum.String())
 	require.NoError(t, err)
 	require.Empty(t, stderr)
 	props, err = properties.LoadFromSlice(