Skip to content

Commit 621052d

Browse files
alessio-peruginialessio-perugini
committed
add the new props in the boards.Search func
1 parent 9188b59 commit 621052d

File tree

2 files changed

+116
-92
lines changed

2 files changed

+116
-92
lines changed

Diff for: ‎commands/board/search.go

+2
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,15 @@ func Search(ctx context.Context, req *rpc.BoardSearchRequest) (*rpc.BoardSearchR
5454
Website: platform.Package.WebsiteURL,
5555
Email: platform.Package.Email,
5656
ManuallyInstalled: platform.ManuallyInstalled,
57+
Indexed: platform.Indexed,
5758
}
5859

5960
if latestPlatformRelease != nil {
6061
rpcPlatform.Latest = latestPlatformRelease.Version.String()
6162
}
6263
if installedPlatformRelease != nil {
6364
rpcPlatform.Installed = installedPlatformRelease.Version.String()
65+
rpcPlatform.MissingMetadata = !installedPlatformRelease.HasMetadata()
6466
}
6567

6668
// Platforms that are not installed don't have a list of boards

Diff for: ‎commands/core/search_test.go

+114-92
Original file line numberDiff line numberDiff line change
@@ -53,28 +53,32 @@ func TestPlatformSearch(t *testing.T) {
5353

5454
require.Len(t, res.SearchOutput, 2)
5555
require.Contains(t, res.SearchOutput, &rpc.Platform{
56-
Id: "Retrokits-RK002:arm",
57-
Installed: "",
58-
Latest: "1.0.5",
59-
Name: "RK002",
60-
Maintainer: "Retrokits (www.retrokits.com)",
61-
Website: "https://www.retrokits.com",
62-
Email: "[email protected]",
63-
Boards: []*rpc.Board{{Name: "RK002"}},
64-
Type: []string{"Contributed"},
65-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
56+
Id: "Retrokits-RK002:arm",
57+
Installed: "",
58+
Latest: "1.0.5",
59+
Name: "RK002",
60+
Maintainer: "Retrokits (www.retrokits.com)",
61+
Website: "https://www.retrokits.com",
62+
Email: "[email protected]",
63+
Boards: []*rpc.Board{{Name: "RK002"}},
64+
Type: []string{"Contributed"},
65+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
66+
Indexed: true,
67+
MissingMetadata: true,
6668
})
6769
require.Contains(t, res.SearchOutput, &rpc.Platform{
68-
Id: "Retrokits-RK002:arm",
69-
Installed: "",
70-
Latest: "1.0.6",
71-
Name: "RK002",
72-
Maintainer: "Retrokits (www.retrokits.com)",
73-
Website: "https://www.retrokits.com",
74-
Email: "[email protected]",
75-
Boards: []*rpc.Board{{Name: "RK002"}},
76-
Type: []string{"Contributed"},
77-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
70+
Id: "Retrokits-RK002:arm",
71+
Installed: "",
72+
Latest: "1.0.6",
73+
Name: "RK002",
74+
Maintainer: "Retrokits (www.retrokits.com)",
75+
Website: "https://www.retrokits.com",
76+
Email: "[email protected]",
77+
Boards: []*rpc.Board{{Name: "RK002"}},
78+
Type: []string{"Contributed"},
79+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
80+
Indexed: true,
81+
MissingMetadata: true,
7882
})
7983

8084
res, stat = PlatformSearch(&rpc.PlatformSearchRequest{
@@ -86,16 +90,18 @@ func TestPlatformSearch(t *testing.T) {
8690
require.NotNil(t, res)
8791
require.Len(t, res.SearchOutput, 1)
8892
require.Contains(t, res.SearchOutput, &rpc.Platform{
89-
Id: "Retrokits-RK002:arm",
90-
Installed: "",
91-
Latest: "1.0.6",
92-
Name: "RK002",
93-
Maintainer: "Retrokits (www.retrokits.com)",
94-
Website: "https://www.retrokits.com",
95-
Email: "[email protected]",
96-
Boards: []*rpc.Board{{Name: "RK002"}},
97-
Type: []string{"Contributed"},
98-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
93+
Id: "Retrokits-RK002:arm",
94+
Installed: "",
95+
Latest: "1.0.6",
96+
Name: "RK002",
97+
Maintainer: "Retrokits (www.retrokits.com)",
98+
Website: "https://www.retrokits.com",
99+
Email: "[email protected]",
100+
Boards: []*rpc.Board{{Name: "RK002"}},
101+
Type: []string{"Contributed"},
102+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
103+
Indexed: true,
104+
MissingMetadata: true,
99105
})
100106

101107
// Search the Package Maintainer
@@ -108,28 +114,32 @@ func TestPlatformSearch(t *testing.T) {
108114
require.NotNil(t, res)
109115
require.Len(t, res.SearchOutput, 2)
110116
require.Contains(t, res.SearchOutput, &rpc.Platform{
111-
Id: "Retrokits-RK002:arm",
112-
Installed: "",
113-
Latest: "1.0.5",
114-
Name: "RK002",
115-
Maintainer: "Retrokits (www.retrokits.com)",
116-
Website: "https://www.retrokits.com",
117-
Email: "[email protected]",
118-
Boards: []*rpc.Board{{Name: "RK002"}},
119-
Type: []string{"Contributed"},
120-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
117+
Id: "Retrokits-RK002:arm",
118+
Installed: "",
119+
Latest: "1.0.5",
120+
Name: "RK002",
121+
Maintainer: "Retrokits (www.retrokits.com)",
122+
Website: "https://www.retrokits.com",
123+
Email: "[email protected]",
124+
Boards: []*rpc.Board{{Name: "RK002"}},
125+
Type: []string{"Contributed"},
126+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
127+
Indexed: true,
128+
MissingMetadata: true,
121129
})
122130
require.Contains(t, res.SearchOutput, &rpc.Platform{
123-
Id: "Retrokits-RK002:arm",
124-
Installed: "",
125-
Latest: "1.0.6",
126-
Name: "RK002",
127-
Maintainer: "Retrokits (www.retrokits.com)",
128-
Website: "https://www.retrokits.com",
129-
Email: "[email protected]",
130-
Boards: []*rpc.Board{{Name: "RK002"}},
131-
Type: []string{"Contributed"},
132-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
131+
Id: "Retrokits-RK002:arm",
132+
Installed: "",
133+
Latest: "1.0.6",
134+
Name: "RK002",
135+
Maintainer: "Retrokits (www.retrokits.com)",
136+
Website: "https://www.retrokits.com",
137+
Email: "[email protected]",
138+
Boards: []*rpc.Board{{Name: "RK002"}},
139+
Type: []string{"Contributed"},
140+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
141+
Indexed: true,
142+
MissingMetadata: true,
133143
})
134144

135145
// Search using the Package name
@@ -142,28 +152,32 @@ func TestPlatformSearch(t *testing.T) {
142152
require.NotNil(t, res)
143153
require.Len(t, res.SearchOutput, 2)
144154
require.Contains(t, res.SearchOutput, &rpc.Platform{
145-
Id: "Retrokits-RK002:arm",
146-
Installed: "",
147-
Latest: "1.0.5",
148-
Name: "RK002",
149-
Maintainer: "Retrokits (www.retrokits.com)",
150-
Website: "https://www.retrokits.com",
151-
Email: "[email protected]",
152-
Boards: []*rpc.Board{{Name: "RK002"}},
153-
Type: []string{"Contributed"},
154-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
155+
Id: "Retrokits-RK002:arm",
156+
Installed: "",
157+
Latest: "1.0.5",
158+
Name: "RK002",
159+
Maintainer: "Retrokits (www.retrokits.com)",
160+
Website: "https://www.retrokits.com",
161+
Email: "[email protected]",
162+
Boards: []*rpc.Board{{Name: "RK002"}},
163+
Type: []string{"Contributed"},
164+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
165+
Indexed: true,
166+
MissingMetadata: true,
155167
})
156168
require.Contains(t, res.SearchOutput, &rpc.Platform{
157-
Id: "Retrokits-RK002:arm",
158-
Installed: "",
159-
Latest: "1.0.6",
160-
Name: "RK002",
161-
Maintainer: "Retrokits (www.retrokits.com)",
162-
Website: "https://www.retrokits.com",
163-
Email: "[email protected]",
164-
Boards: []*rpc.Board{{Name: "RK002"}},
165-
Type: []string{"Contributed"},
166-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
169+
Id: "Retrokits-RK002:arm",
170+
Installed: "",
171+
Latest: "1.0.6",
172+
Name: "RK002",
173+
Maintainer: "Retrokits (www.retrokits.com)",
174+
Website: "https://www.retrokits.com",
175+
Email: "[email protected]",
176+
Boards: []*rpc.Board{{Name: "RK002"}},
177+
Type: []string{"Contributed"},
178+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
179+
Indexed: true,
180+
MissingMetadata: true,
167181
})
168182

169183
// Search using the Platform name
@@ -176,28 +190,32 @@ func TestPlatformSearch(t *testing.T) {
176190
require.NotNil(t, res)
177191
require.Len(t, res.SearchOutput, 2)
178192
require.Contains(t, res.SearchOutput, &rpc.Platform{
179-
Id: "Retrokits-RK002:arm",
180-
Installed: "",
181-
Latest: "1.0.5",
182-
Name: "RK002",
183-
Maintainer: "Retrokits (www.retrokits.com)",
184-
Website: "https://www.retrokits.com",
185-
Email: "[email protected]",
186-
Boards: []*rpc.Board{{Name: "RK002"}},
187-
Type: []string{"Contributed"},
188-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
193+
Id: "Retrokits-RK002:arm",
194+
Installed: "",
195+
Latest: "1.0.5",
196+
Name: "RK002",
197+
Maintainer: "Retrokits (www.retrokits.com)",
198+
Website: "https://www.retrokits.com",
199+
Email: "[email protected]",
200+
Boards: []*rpc.Board{{Name: "RK002"}},
201+
Type: []string{"Contributed"},
202+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
203+
Indexed: true,
204+
MissingMetadata: true,
189205
})
190206
require.Contains(t, res.SearchOutput, &rpc.Platform{
191-
Id: "Retrokits-RK002:arm",
192-
Installed: "",
193-
Latest: "1.0.6",
194-
Name: "RK002",
195-
Maintainer: "Retrokits (www.retrokits.com)",
196-
Website: "https://www.retrokits.com",
197-
Email: "[email protected]",
198-
Boards: []*rpc.Board{{Name: "RK002"}},
199-
Type: []string{"Contributed"},
200-
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
207+
Id: "Retrokits-RK002:arm",
208+
Installed: "",
209+
Latest: "1.0.6",
210+
Name: "RK002",
211+
Maintainer: "Retrokits (www.retrokits.com)",
212+
Website: "https://www.retrokits.com",
213+
Email: "[email protected]",
214+
Boards: []*rpc.Board{{Name: "RK002"}},
215+
Type: []string{"Contributed"},
216+
Help: &rpc.HelpResources{Online: "https://www.retrokits.com/rk002/arduino"},
217+
Indexed: true,
218+
MissingMetadata: true,
201219
})
202220

203221
// Search using a board name
@@ -246,7 +264,9 @@ func TestPlatformSearch(t *testing.T) {
246264
{Name: "Arduino Industrial 101"},
247265
{Name: "Linino One"},
248266
},
249-
Help: &rpc.HelpResources{Online: "http://www.arduino.cc/en/Reference/HomePage"},
267+
Help: &rpc.HelpResources{Online: "http://www.arduino.cc/en/Reference/HomePage"},
268+
Indexed: true,
269+
MissingMetadata: true,
250270
})
251271

252272
res, stat = PlatformSearch(&rpc.PlatformSearchRequest{
@@ -294,7 +314,9 @@ func TestPlatformSearch(t *testing.T) {
294314
{Name: "Arduino Industrial 101"},
295315
{Name: "Linino One"},
296316
},
297-
Help: &rpc.HelpResources{Online: "http://www.arduino.cc/en/Reference/HomePage"},
317+
Help: &rpc.HelpResources{Online: "http://www.arduino.cc/en/Reference/HomePage"},
318+
Indexed: true,
319+
MissingMetadata: true,
298320
})
299321
}
300322

0 commit comments

Comments
 (0)