Add check for sketch name mismatch

Author: per1234

Diff for: check/checkconfigurations/checkconfigurations.go

@@ -1241,6 +1241,21 @@ var configurations = []Type{
 		ErrorModes:      []checkmode.Type{checkmode.Default},
 		CheckFunction:   checkfunctions.SketchDotJSONFormat,
 	},
+	{
+		ProjectType:     projecttype.Sketch,
+		Category:        "structure",
+		Subcategory:     "",
+		ID:              "",
+		Brief:           "name mismatch",
+		Description:     "",
+		MessageTemplate: "Sketch file/folder name mismatch. The primary sketch file name must match the folder: {{.}}. See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file",
+		DisableModes:    nil,
+		EnableModes:     []checkmode.Type{checkmode.Default},
+		InfoModes:       nil,
+		WarningModes:    []checkmode.Type{checkmode.Permissive},
+		ErrorModes:      []checkmode.Type{checkmode.Default},
+		CheckFunction:   checkfunctions.SketchNameMismatch,
+	},
 	{
 		ProjectType:     projecttype.Sketch,
 		Category:        "code",

Diff for: check/checkfunctions/sketch.go

@@ -23,6 +23,7 @@ import (
 	"github.com/arduino/arduino-check/check/checkdata"
 	"github.com/arduino/arduino-check/check/checkresult"
 	"github.com/arduino/arduino-check/project/sketch"
+	"github.com/arduino/arduino-cli/arduino/globals"
 )
 
 // IncorrectSketchSrcFolderNameCase checks for incorrect case of src subfolder name in recursive format libraries.
@@ -128,3 +129,20 @@ func SketchDotJSONFormat() (result checkresult.Type, output string) {
 
 	return checkresult.Fail, checkdata.MetadataLoadError().Error()
 }
+
+// SketchNameMismatch checks for mismatch between sketch folder name and primary file name.
+func SketchNameMismatch() (result checkresult.Type, output string) {
+	for extension := range globals.MainFileValidExtensions {
+		validPrimarySketchFilePath := checkdata.ProjectPath().Join(checkdata.ProjectPath().Base() + extension)
+		exist, err := validPrimarySketchFilePath.ExistCheck()
+		if err != nil {
+			panic(err)
+		}
+
+		if exist {
+			return checkresult.Pass, ""
+		}
+	}
+
+	return checkresult.Fail, checkdata.ProjectPath().Base() + ".ino"
+}

Diff for: check/checkfunctions/sketch_test.go

@@ -116,3 +116,12 @@ func TestSketchDotJSONFormat(t *testing.T) {
 
 	checkSketchCheckFunction(SketchDotJSONFormat, testTables, t)
 }
+
+func TestSketchNameMismatch(t *testing.T) {
+	testTables := []sketchCheckFunctionTestTable{
+		{"Valid", "Valid", checkresult.Pass, ""},
+		{"Mismatch", "NameMismatch", checkresult.Fail, ""},
+	}
+
+	checkSketchCheckFunction(SketchNameMismatch, testTables, t)
+}

Diff for: check/checkfunctions/testdata/sketches/NameMismatch/Mismatch.ino

@@ -0,0 +1,2 @@
+void setup() {}
+void loop() {}