Applied review suggestions

* rename --silent to --quiet
* removed useless 'settings' variable

Author: cmaglie

Diff for: cli/monitor/monitor.go

@@ -42,7 +42,7 @@ var tr = i18n.Tr
 var portArgs arguments.Port
 var describe bool
 var configs []string
-var silent bool
+var quiet bool
 
 // NewCommand created a new `monitor` command
 func NewCommand() *cobra.Command {
@@ -58,7 +58,7 @@ func NewCommand() *cobra.Command {
 	portArgs.AddToCommand(cmd)
 	cmd.Flags().BoolVar(&describe, "describe", false, tr("Show all the settings of the communication port."))
 	cmd.Flags().StringSliceVarP(&configs, "config", "c", []string{}, tr("Configuration of the port."))
-	cmd.Flags().BoolVarP(&silent, "silent", "s", false, tr("Run in silent mode, show only monitor input and output."))
+	cmd.Flags().BoolVarP(&quiet, "quiet", "q", false, tr("Run in silent mode, show only monitor input and output."))
 	cmd.MarkFlagRequired("port")
 	return cmd
 }
@@ -67,7 +67,7 @@ func runMonitorCmd(cmd *cobra.Command, args []string) {
 	instance := instance.CreateAndInit()
 
 	if !configuration.HasConsole {
-		silent = true
+		quiet = true
 	}
 
 	port, err := portArgs.GetPort(instance, nil)
@@ -108,7 +108,6 @@ func runMonitorCmd(cmd *cobra.Command, args []string) {
 			feedback.Error(err)
 			os.Exit(errorcodes.ErrGeneric)
 		}
-		settings := resp.GetSettings()
 		for _, config := range configs {
 			split := strings.SplitN(config, "=", 2)
 			k := ""
@@ -119,7 +118,7 @@ func runMonitorCmd(cmd *cobra.Command, args []string) {
 			}
 
 			var setting *rpc.MonitorPortSettingDescriptor
-			for _, s := range settings {
+			for _, s := range resp.GetSettings() {
 				if k == "" {
 					if contains(s.EnumValues, v) {
 						setting = s
@@ -144,7 +143,7 @@ func runMonitorCmd(cmd *cobra.Command, args []string) {
 				SettingId: setting.SettingId,
 				Value:     v,
 			})
-			if !silent {
+			if !quiet {
 				feedback.Print(fmt.Sprintf("Set %s to %s", setting.SettingId, v))
 			}
 		}
@@ -177,7 +176,7 @@ func runMonitorCmd(cmd *cobra.Command, args []string) {
 		cancel()
 	}()
 
-	if !silent {
+	if !quiet {
 		feedback.Print(tr("Connected to %s! Press CTRL-C to exit.", port.String()))
 	}
 

Diff for: i18n/data/en.po

@@ -427,7 +427,7 @@ msgstr "Configuring platform."
 msgid "Connected"
 msgstr "Connected"
 
-#: cli/monitor/monitor.go:181
+#: cli/monitor/monitor.go:180
 msgid "Connected to %s! Press CTRL-C to exit."
 msgstr "Connected to %s! Press CTRL-C to exit."
 
@@ -504,7 +504,7 @@ msgstr "Debugging not supported for board %s"
 msgid "Debugging supported:"
 msgstr "Debugging supported:"
 
-#: cli/monitor/monitor.go:199
+#: cli/monitor/monitor.go:198
 msgid "Default"
 msgstr "Default"
 
@@ -1138,7 +1138,7 @@ msgstr "Global variables use {0} bytes of dynamic memory."
 
 #: cli/core/list.go:84
 #: cli/core/search.go:114
-#: cli/monitor/monitor.go:199
+#: cli/monitor/monitor.go:198
 #: cli/outdated/outdated.go:62
 msgid "ID"
 msgstr "ID"
@@ -1727,8 +1727,8 @@ msgstr "Platform size (bytes):"
 msgid "Port"
 msgstr "Port"
 
-#: cli/monitor/monitor.go:168
-#: cli/monitor/monitor.go:175
+#: cli/monitor/monitor.go:167
+#: cli/monitor/monitor.go:174
 msgid "Port closed:"
 msgstr "Port closed:"
 
@@ -1869,7 +1869,7 @@ msgstr "Sets a setting value."
 msgid "Sets where to save the configuration file."
 msgstr "Sets where to save the configuration file."
 
-#: cli/monitor/monitor.go:199
+#: cli/monitor/monitor.go:198
 msgid "Setting"
 msgstr "Setting"
 
@@ -2344,7 +2344,7 @@ msgstr "VERSION"
 msgid "VERSION_NUMBER"
 msgstr "VERSION_NUMBER"
 
-#: cli/monitor/monitor.go:199
+#: cli/monitor/monitor.go:198
 msgid "Values"
 msgstr "Values"
 
@@ -2851,11 +2851,11 @@ msgstr "invalid platform archive size: %s"
 msgid "invalid pluggable monitor reference: %s"
 msgstr "invalid pluggable monitor reference: %s"
 
-#: cli/monitor/monitor.go:131
+#: cli/monitor/monitor.go:130
 msgid "invalid port configuration value for %s: %s"
 msgstr "invalid port configuration value for %s: %s"
 
-#: cli/monitor/monitor.go:140
+#: cli/monitor/monitor.go:139
 msgid "invalid port configuration: %s"
 msgstr "invalid port configuration: %s"