Fixed TestUserAgentHeader and TestProxy

Author: cmaglie

.golangci.yml

@@ -134,5 +134,7 @@ issues:
     - path-except: internal/cli/
       linters:
         - forbidigo
+    - path: internal/cli/.*_test.go
+      linters: [forbidigo]
     - path: internal/cli/feedback/
       linters: [forbidigo]

internal/cli/configuration/defaults.go

@@ -64,6 +64,10 @@ func SetDefaults(settings *Settings) {
 
 	// updater settings
 	setDefaultValueAndKeyTypeSchema("updater.enable_notification", true)
+
+	// network settings
+	setKeyTypeSchema("network.proxy", "")
+	setKeyTypeSchema("network.user_agent_ext", "")
 }
 
 // BindEnvVars binds environment variables to the settings

internal/cli/configuration/network_test.go

@@ -33,7 +33,7 @@ func TestUserAgentHeader(t *testing.T) {
 	defer ts.Close()
 
 	settings := configuration.NewSettings()
-	settings.Set("network.user_agent_ext", "test-user-agent")
+	require.NoError(t, settings.Set("network.user_agent_ext", "test-user-agent"))
 	client, err := settings.NewHttpClient()
 	require.NoError(t, err)
 
@@ -46,6 +46,7 @@ func TestUserAgentHeader(t *testing.T) {
 	b, err := io.ReadAll(response.Body)
 	require.NoError(t, err)
 
+	fmt.Println("RESPONSE:", string(b))
 	require.Contains(t, string(b), "test-user-agent")
 }