Skip to content

Commit 4b9b6ae

Browse files
committed
Fixed TestUserAgentHeader and TestProxy
1 parent 0c9415c commit 4b9b6ae

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Diff for: internal/cli/configuration/defaults.go

+4
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,10 @@ func SetDefaults(settings *Settings) {
6464

6565
// updater settings
6666
setDefaultValueAndKeyTypeSchema("updater.enable_notification", true)
67+
68+
// network settings
69+
setKeyTypeSchema("network.proxy", "")
70+
setKeyTypeSchema("network.user_agent_ext", "")
6771
}
6872

6973
// BindEnvVars binds environment variables to the settings

Diff for: internal/cli/configuration/network_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func TestUserAgentHeader(t *testing.T) {
3333
defer ts.Close()
3434

3535
settings := configuration.NewSettings()
36-
settings.Set("network.user_agent_ext", "test-user-agent")
36+
require.NoError(t, settings.Set("network.user_agent_ext", "test-user-agent"))
3737
client, err := settings.NewHttpClient()
3838
require.NoError(t, err)
3939

@@ -46,6 +46,7 @@ func TestUserAgentHeader(t *testing.T) {
4646
b, err := io.ReadAll(response.Body)
4747
require.NoError(t, err)
4848

49+
fmt.Println("RESPONSE:", string(b))
4950
require.Contains(t, string(b), "test-user-agent")
5051
}
5152

0 commit comments

Comments
 (0)