Skip to content

Commit 4942be4

Browse files
author
Mattia Bertorello
committed
Fixed all the problem reported by interfacer (replace with the interface when is possible)
These warnings were suppressed by putting the type in the name of the method
1 parent 88f5df5 commit 4942be4

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

Diff for: .golangci.yml

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ linters:
2525
- goconst
2626
- gocyclo
2727
- govet
28-
- interfacer
2928
- lll
3029
- maligned
3130
- megacheck

Diff for: arduino/cores/cores.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,10 @@ func (platform *Platform) GetOrCreateRelease(version *semver.Version) (*Platform
111111
return release, nil
112112
}
113113

114-
// GetRelease returns the specified release corresponding the provided version,
114+
// GetReleaseRelaxedVersion returns the specified release corresponding the provided version,
115115
// or nil if not found.
116-
func (platform *Platform) GetRelease(version *semver.Version) *PlatformRelease {
116+
func (platform *Platform) GetReleaseVersion(version *semver.Version) *PlatformRelease {
117+
// use as an fmt.Stringer
117118
return platform.Releases[version.String()]
118119
}
119120

@@ -124,7 +125,7 @@ func (platform *Platform) GetLatestRelease() *PlatformRelease {
124125
if latestVersion == nil {
125126
return nil
126127
}
127-
return platform.GetRelease(latestVersion)
128+
return platform.GetReleaseVersion(latestVersion)
128129
}
129130

130131
// GetAllReleasesVersions returns all the version numbers in this Platform Package.

Diff for: arduino/cores/packagemanager/download.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func (pm *PackageManager) FindPlatformReleaseDependencies(item *PlatformReferenc
8181

8282
var release *cores.PlatformRelease
8383
if item.PlatformVersion != nil {
84-
release = platform.GetRelease(item.PlatformVersion)
84+
release = platform.GetReleaseVersion(item.PlatformVersion)
8585
if release == nil {
8686
return nil, nil, fmt.Errorf("required version %s not found for platform %s", item.PlatformVersion, platform.String())
8787
}

Diff for: arduino/cores/packagemanager/package_manager.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ func (ta *ToolActions) Release(version *semver.RelaxedVersion) *ToolReleaseActio
288288
if ta.forwardError != nil {
289289
return &ToolReleaseActions{forwardError: ta.forwardError}
290290
}
291-
release := ta.tool.GetRelease(version)
291+
release := ta.tool.GetReleaseRelaxedVersion(version)
292292
if release == nil {
293293
return &ToolReleaseActions{forwardError: fmt.Errorf("release %s not found for tool %s", version, ta.tool.String())}
294294
}

Diff for: arduino/cores/tools.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ func (tool *Tool) GetOrCreateRelease(version *semver.RelaxedVersion) *ToolReleas
6262
return release
6363
}
6464

65-
// GetRelease returns the specified release corresponding the provided version,
65+
// GetReleaseRelaxedVersion returns the specified release corresponding the provided version,
6666
// or nil if not found.
67-
func (tool *Tool) GetRelease(version *semver.RelaxedVersion) *ToolRelease {
67+
func (tool *Tool) GetReleaseRelaxedVersion(version *semver.RelaxedVersion) *ToolRelease {
6868
return tool.Releases[version.String()]
6969
}
7070

@@ -86,7 +86,7 @@ func (tool *Tool) LatestRelease() *ToolRelease {
8686
return nil
8787
}
8888

89-
return tool.GetRelease(latest)
89+
return tool.GetReleaseRelaxedVersion(latest)
9090
}
9191

9292
// latestReleaseVersion obtains latest version number.

0 commit comments

Comments
 (0)